public inbox for
 help / color / mirror / Atom feed
From: Mark Wielaard <>
To: Joshua Watt <>
Subject: Re: [PATCH] Fix include path separator
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Joshua,

[Note that the mailinglist doesn't accept HTML emails, so you message
isn't in the archives.]

On Wed, Jul 03, 2019 at 03:49:45PM -0500, Joshua Watt wrote:
> On Wed, Jul 3, 2019, 2:04 PM Mark Wielaard <> wrote:
> > I think this makes total sense. And I see something similar is already
> > on the 1.1.x branch. But I am slightly hesitant making any build
> > changes. Especially since we don't have any buildbots for Windows. And
> > I personally don't have any access to Windows.
> >
> I did tests with msvc 18.0 (visual studio 2013), and I can probably get
> some newer versions if you want. I can also try with mingw gcc (on Windows;
> already verified on Linux) if you like... I'm not sure what else would be a
> relevant test

Newer compiler are likely to accept it if older ones did.
It has been there since almost the beginning, bzip2-0.9.0c, 1998.
So maybe at some time there were compilers that needed the backslash?

> > Are you sure all Windows compilers accept the forward instead of
> > backwards slash for standard include statements?
> > Is there anything in the C standard that say a forward (or backwards)
> > slash should be accepted?
> >
> Not AFAIK. FWIW, windows itself doesn't care about the slash direction for
> anything except UNC paths, so unless the compilers have really bad path
> parsing logic, it shouldn't matter.

Actually I found the following in the C89 standard about #include
directive parsing:

   If the characters ', \ , , or /* occur in the sequence between the 
   < and > delimiters, the behavior is undefined.

So, it seems accepting \ instead of / is actually an extension.

> > Sorry for being a little pedantic when it comes to build changes.
> >
> It's understandable :)

Maybe a little too pedantic. I cannot really find any references for
sys\stat.h except where sys/stat.h is also accepted. The code mentions
the lcc compiler and MS Visual C compiler. As far as I can see
(quickly reading the documentation) the lcc compile accepts
sys/stat.h. And you tested the Microsoft visual C compiler (and
MINGW). It also moves us closer to the experimental 1.1.x branch.

So lets just accept it. Pushed.



      parent reply	other threads:[~2019-07-04 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 Joshua Watt
2019-01-01  0:00 ` Mark Wielaard
     [not found]   ` <>
2019-01-01  0:00     ` _stati64 patch (Was: [PATCH] Fix include path separator) Mark Wielaard
2019-01-01  0:00       ` Joshua Watt
2019-01-01  0:00         ` Mark Wielaard
2019-01-01  0:00           ` Joshua Watt
2019-01-01  0:00             ` Mark Wielaard
2019-01-01  0:00               ` Joshua Watt
2019-01-01  0:00                 ` Mark Wielaard
2019-01-01  0:00                   ` Joshua Watt
2019-01-01  0:00     ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).