From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43534 invoked by alias); 5 Jul 2019 08:39:02 -0000 Mailing-List: contact bzip2-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Sender: bzip2-devel-owner@sourceware.org Received: (qmail 42876 invoked by uid 89); 5 Jul 2019 08:39:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Mark Wielaard To: Joshua Watt Cc: bzip2-devel@sourceware.org, Phil Ross Subject: _stati64 patch (Was: [PATCH] Fix include path separator) Message-ID: <20190705083857.GF4777@wildebeest.org> References: <20190702200544.27137-1-JPEW.hacker@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="QTprm0S8XgL7H0Dt" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-SW-Source: 2019-q3/txt/msg00015.txt.bz2 --QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 775 Hi, On Wed, Jul 03, 2019 at 03:49:45PM -0500, Joshua Watt wrote: > I did tests with msvc 18.0 (visual studio 2013), and I can probably get > some newer versions if you want. I can also try with mingw gcc (on Windows; > already verified on Linux) if you like... I'm not sure what else would be a > relevant test There is another Windows specific patch which we haven't applied yet to the 1.0.x branch because we don't have Windows builders/testers. It is the attached patch from Phil Ross (CCed) to use _stati64 instead of _stat to support large >4GB files on Windows. If you could test the above works on your setups that would be appreciated. Do we need any checks to see whether _stati64 is available? Or can it be used unconditionally as in this patch? Thanks, Mark --QTprm0S8XgL7H0Dt Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-a-not-a-normal-file-error-when-compressing-large.patch" Content-length: 1338 >From c0ee33ad3d6108eb6f7ddaf71bcc22ea7a3f855f Mon Sep 17 00:00:00 2001 From: Phil Ross Date: Tue, 21 May 2019 20:46:14 +0100 Subject: [PATCH] Fix a 'not a normal file' error when compressing large files. The bzip2 command line would report 'not a normal file' for files of size larger than 2^32 - 1 bytes. Patch bzip2.c to use _stati64 instead of _stat so that a successful result is returned for large files. Resolves https://github.com/philr/bzip2-windows/issues/3. --- patches/06-support_64bit_file_sizes.diff | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 patches/06-support_64bit_file_sizes.diff diff --git a/patches/06-support_64bit_file_sizes.diff b/patches/06-support_64bit_file_sizes.diff new file mode 100644 index 0000000..abf1425 --- /dev/null +++ b/patches/06-support_64bit_file_sizes.diff @@ -0,0 +1,13 @@ +--- bzip2-1.0.6.orig/bzip2.c 2010-09-11 00:04:53.000000000 +0100 ++++ bzip2-1.0.6/bzip2.c 2019-05-21 20:40:43.699892600 +0100 +@@ -132,8 +132,8 @@ + + # define NORETURN /**/ + # define PATH_SEP '\\' +-# define MY_LSTAT _stat +-# define MY_STAT _stat ++# define MY_LSTAT _stati64 ++# define MY_STAT _stati64 + # define MY_S_ISREG(x) ((x) & _S_IFREG) + # define MY_S_ISDIR(x) ((x) & _S_IFDIR) + -- 2.20.1 --QTprm0S8XgL7H0Dt--