From: Joshua Watt <jpewhacker@gmail.com>
To: Mark Wielaard <mark@klomp.org>
Cc: bzip2-devel@sourceware.org, Phil Ross <phil.ross@gmail.com>
Subject: Re: _stati64 patch (Was: [PATCH] Fix include path separator)
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <5867f77d-36b1-5ae2-1b53-5e1ee5a63323@gmail.com> (raw)
In-Reply-To: <20190705083857.GF4777@wildebeest.org>
On 7/5/19 3:38 AM, Mark Wielaard wrote:
> Hi,
>
> On Wed, Jul 03, 2019 at 03:49:45PM -0500, Joshua Watt wrote:
>> I did tests with msvc 18.0 (visual studio 2013), and I can probably get
>> some newer versions if you want. I can also try with mingw gcc (on Windows;
>> already verified on Linux) if you like... I'm not sure what else would be a
>> relevant test
> There is another Windows specific patch which we haven't applied yet
> to the 1.0.x branch because we don't have Windows builders/testers.
>
> It is the attached patch from Phil Ross (CCed) to use _stati64 instead
> of _stat to support large >4GB files on Windows.
>
> If you could test the above works on your setups that would be
> appreciated. Do we need any checks to see whether _stati64 is
> available? Or can it be used unconditionally as in this patch?
The patch compiles without issues using msvc 18.0 (Visual Studio 2013)
and 64-bit MinGW gcc 7.3.0. 'make test' passes also.
The "patch in a patch" format was a little confusing at first :)
>
> Thanks,
>
> Mark
next prev parent reply other threads:[~2019-07-09 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [PATCH] Fix include path separator Joshua Watt
2019-01-01 0:00 ` Mark Wielaard
[not found] ` <CAJdd5GZfTk8EKeUE_C1keKm+gn=qapv9OQGGariiiXP9jyu0wQ@mail.gmail.com>
2019-01-01 0:00 ` _stati64 patch (Was: [PATCH] Fix include path separator) Mark Wielaard
2019-01-01 0:00 ` Joshua Watt [this message]
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Joshua Watt
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Joshua Watt
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Joshua Watt
2019-01-01 0:00 ` [PATCH] Fix include path separator Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5867f77d-36b1-5ae2-1b53-5e1ee5a63323@gmail.com \
--to=jpewhacker@gmail.com \
--cc=bzip2-devel@sourceware.org \
--cc=mark@klomp.org \
--cc=phil.ross@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).