From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102332 invoked by alias); 9 Jul 2019 15:00:51 -0000 Mailing-List: contact bzip2-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Sender: bzip2-devel-owner@sourceware.org Received: (qmail 102138 invoked by uid 89); 9 Jul 2019 15:00:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:209.85.166.67, HX-Spam-Relays-External:209.85.166.67 X-Spam-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: * X-HELO: mail-io1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=iugJVLLfGYwfbgxD0HZYjhAICv6R15ZZR1XiYNT4O6k=; b=TJPxSUMIzlyGOlaengWAyM3OJoPDxQn7TA5/5Y2AeOoLH/FxKsa71Kj9p4FnDT1NAG 8duaI6AxvZN+i62oZfUrS048xvloA5WrSuNIXfBaot51yzXlLLpIoabfP5qkhfFzmFuK BCmgl2jQSr8FuFbdGrxp0Ubmfk7XIBNFZ9C6safnqbHkZzBhWb+QxuJmOygq7ibVGYG4 SODDnmRLxMju6qQrXpqhZ0r7zOXuZdpsGd51YUpn5r1j870F48zvrqgf4LZff+0QIRdY FXKo7SPh1Ffz4w6rwRVFj5sUnlImQmpMDRUNTrkVhDFhcdcYfrPwhDxSMtOpfrGQRSSW bWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iugJVLLfGYwfbgxD0HZYjhAICv6R15ZZR1XiYNT4O6k=; b=hJUAkaqKmuhv6DOJ6xzDze5vDoZOZCqNWC7XHMhw6uTEcAmQpPL+dqLe8dbnsnibek qIouVoE+T+ni+J7oTPvDYXL5cy7hmgcZBHtA6LBkx1Yyhfzvhs4CkkQ6O/YXIL6479qK GDLD8LhRs86KYgcHmRKz06ohokBcfjPX8CutCR6zO2nAWWSylBPiNVuBSOn4A8P6RcuS wKOAOXfC6gBH62Q5PmVBx02RXZYafoaz/eqs2C7Z2gN+fBcvuHzcoDbKSD9f4gyJtWvb 1CGG3AjEqfzWmlc/MK/unx3UihNVC4PTrE0Q0rBVphOWewZ/koOgSFIht1YqtSEQce1c Sqig== X-Gm-Message-State: APjAAAXcGemp89/9xfGYGDRPrRZATgF65wBYTszXPHBU+MO0QvZxt+l7 8eNBsqRmPvTiLZsgO31diArVKHn6 X-Google-Smtp-Source: APXvYqxr9oeiYTBkeJ+rggAmdfsBp4uYwjTBfbLk/N3rfDhktts4OO1YJr6RJBcPf+SqoOx9NeSvvg== X-Received: by 2002:a6b:790a:: with SMTP id i10mr27842iop.150.1562684448583; Tue, 09 Jul 2019 08:00:48 -0700 (PDT) From: Joshua Watt X-Google-Original-From: Joshua Watt Subject: Re: _stati64 patch (Was: [PATCH] Fix include path separator) To: Mark Wielaard Cc: bzip2-devel@sourceware.org, Phil Ross References: <20190702200544.27137-1-JPEW.hacker@gmail.com> <20190705083857.GF4777@wildebeest.org> Message-ID: <5867f77d-36b1-5ae2-1b53-5e1ee5a63323@gmail.com> Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190705083857.GF4777@wildebeest.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SW-Source: 2019-q3/txt/msg00017.txt.bz2 On 7/5/19 3:38 AM, Mark Wielaard wrote: > Hi, > > On Wed, Jul 03, 2019 at 03:49:45PM -0500, Joshua Watt wrote: >> I did tests with msvc 18.0 (visual studio 2013), and I can probably get >> some newer versions if you want. I can also try with mingw gcc (on Windows; >> already verified on Linux) if you like... I'm not sure what else would be a >> relevant test > There is another Windows specific patch which we haven't applied yet > to the 1.0.x branch because we don't have Windows builders/testers. > > It is the attached patch from Phil Ross (CCed) to use _stati64 instead > of _stat to support large >4GB files on Windows. > > If you could test the above works on your setups that would be > appreciated. Do we need any checks to see whether _stati64 is > available? Or can it be used unconditionally as in this patch? The patch compiles without issues using msvc 18.0 (Visual Studio 2013) and 64-bit MinGW gcc 7.3.0. 'make test' passes also. The "patch in a patch" format was a little confusing at first :) > > Thanks, > > Mark