public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: bzip2-devel@sourceware.org
Subject: buildbot for bzip2.git
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <5eea2a43dbe38124a4f1a519f182fb59463e2326.camel@klomp.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Hi,

There is now a buildbot that picks up any commit to the git repository.
It simply tests that the project still compiles and passes all its
checks. It runs on a variety of 32/64bit, little and big endian distros
(centos-aarch64, centos-x86_64, debian-amd64, debian-armhf, debian-
i386, fedora-ppc64, fedora-ppc64le, fedora-s390x and fedora-x86_64),
which will hopefully catch any issues early.

The current state (all green!) can be seen here:
https://builder.wildebeest.org/buildbot/#/builders?tags=bzip2

If the build fails on any buildbot worker it should sent email to this
list.

To test the buildbot setup I pushed the attached commit, which simply
cleans up the only warning given by gcc.

Cheers,

Mark

[-- Attachment #2: 0001-bzip2.c-testStream-Remove-set-but-not-used-nread-var.patch --]
[-- Type: text/x-patch, Size: 1493 bytes --]

From 02fe3ca2349e45eee6dff6ca46bf9a9187f382c5 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Sun, 23 Jun 2019 23:52:03 +0200
Subject: [PATCH] bzip2.c (testStream): Remove set, but not used nread
 variable.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Modern GCC warns:

bzip2.c: In function ‘testStream’:
bzip2.c:557:37: warning: variable ‘nread’ set but not used
[-Wunused-but-set-variable]
    Int32   bzerr, bzerr_dummy, ret, nread, streamNo, i;
                                     ^~~~~

GCC is correct. In testStream we don't care about the number of bytes
read by BZ2_bzRead. So just remove the variable and the assignment.
---
 bzip2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bzip2.c b/bzip2.c
index 59f59ff..854a2bb 100644
--- a/bzip2.c
+++ b/bzip2.c
@@ -554,7 +554,7 @@ static
 Bool testStream ( FILE *zStream )
 {
    BZFILE* bzf = NULL;
-   Int32   bzerr, bzerr_dummy, ret, nread, streamNo, i;
+   Int32   bzerr, bzerr_dummy, ret, streamNo, i;
    UChar   obuf[5000];
    UChar   unused[BZ_MAX_UNUSED];
    Int32   nUnused;
@@ -577,7 +577,7 @@ Bool testStream ( FILE *zStream )
       streamNo++;
 
       while (bzerr == BZ_OK) {
-         nread = BZ2_bzRead ( &bzerr, bzf, obuf, 5000 );
+         BZ2_bzRead ( &bzerr, bzf, obuf, 5000 );
          if (bzerr == BZ_DATA_ERROR_MAGIC) goto errhandler;
       }
       if (bzerr != BZ_STREAM_END) goto errhandler;
-- 
1.8.3.1


                 reply	other threads:[~2019-06-23 22:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eea2a43dbe38124a4f1a519f182fb59463e2326.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=bzip2-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).