From: Sam James <sam@gentoo.org>
To: Eli Schwartz <eschwartz93@gmail.com>
Cc: bzip2-devel@sourceware.org, David Seifert <soap@gentoo.org>
Subject: Re: [PATCH bzip2 6/6] install a pkg-config file with instructions for linking to libbz2
Date: Sun, 23 Oct 2022 17:03:11 +0100 [thread overview]
Message-ID: <72DE8850-4F05-4674-91C9-50ED707F3702@gentoo.org> (raw)
In-Reply-To: <8e1407b5-481c-1e43-a073-c9a1d55aaf5d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
> On 9 Jun 2022, at 06:52, Eli Schwartz via Bzip2-devel <bzip2-devel@sourceware.org> wrote:
>
> On 6/3/22 1:09 AM, ~eschwartz wrote:
>> From: Eli Schwartz <eschwartz93@gmail.com>
>>
>> A pkg-config file is necessary in order to robustly communicate across
>> build systems that bz2 is installed, *where* it is installed, and the
>> correct CFLAGS / LDFLAGS to use in order to compile and link against it.
>
>
> Some distros already provide one of these, so it's currently a bit
> inconsistent how to look for the library. As a result, there is software
> in the wild that probes for the library name, and fails if the library
> is installed to a custom prefix, and other software that checks for
> pkg-config, and fails on distros that don't provide their own bzip2.pc
>
> In general it's good to have.
>
> And particularly, it makes it much easier to detect bzip2 as "a
> dependency" instead of "manual linker flags" from the Meson build
> system, which can then toggle between multiple "dependency" providers
> via e.g.
> https://mesonbuild.com/Wrap-dependency-system-manual.html#provide-section
>
The whole series looks great, thanks for doing this.
Best,
sam
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
next prev parent reply other threads:[~2022-10-23 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 3:45 [PATCH bzip2 1/6] install relative symlinks ~eschwartz
2022-06-03 4:20 ` [PATCH bzip2 2/6] port the build configuration to autoconf ~eschwartz
2022-06-09 5:56 ` Eli Schwartz
2022-06-03 4:48 ` [PATCH bzip2 4/6] make a couple program aliases symlinks instead of copies ~eschwartz
2022-06-03 4:54 ` [PATCH bzip2 5/6] install man page symlinks for a couple more symlinked commands ~eschwartz
2022-06-03 5:09 ` [PATCH bzip2 6/6] install a pkg-config file with instructions for linking to libbz2 ~eschwartz
2022-06-09 5:52 ` Eli Schwartz
2022-10-23 16:03 ` Sam James [this message]
2022-06-09 4:50 ` [PATCH bzip2 3/6] shared Makefile: add install rule ~eschwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72DE8850-4F05-4674-91C9-50ED707F3702@gentoo.org \
--to=sam@gentoo.org \
--cc=bzip2-devel@sourceware.org \
--cc=eschwartz93@gmail.com \
--cc=soap@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).