From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 4166A3858D37 for ; Sun, 23 Oct 2022 16:03:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4166A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Content-Type: multipart/signed; boundary="Apple-Mail=_A17F91E5-46FB-4165-867C-2D2D6A862C71"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH bzip2 6/6] install a pkg-config file with instructions for linking to libbz2 From: Sam James In-Reply-To: <8e1407b5-481c-1e43-a073-c9a1d55aaf5d@gmail.com> Date: Sun, 23 Oct 2022 17:03:11 +0100 Cc: bzip2-devel@sourceware.org, David Seifert Message-Id: <72DE8850-4F05-4674-91C9-50ED707F3702@gentoo.org> References: <165475384722.17277.18269615533597437835-5@git.sr.ht> <8e1407b5-481c-1e43-a073-c9a1d55aaf5d@gmail.com> To: Eli Schwartz X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_A17F91E5-46FB-4165-867C-2D2D6A862C71 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 9 Jun 2022, at 06:52, Eli Schwartz via Bzip2-devel = wrote: >=20 > On 6/3/22 1:09 AM, ~eschwartz wrote: >> From: Eli Schwartz >>=20 >> A pkg-config file is necessary in order to robustly communicate = across >> build systems that bz2 is installed, *where* it is installed, and the >> correct CFLAGS / LDFLAGS to use in order to compile and link against = it. >=20 >=20 > Some distros already provide one of these, so it's currently a bit > inconsistent how to look for the library. As a result, there is = software > in the wild that probes for the library name, and fails if the library > is installed to a custom prefix, and other software that checks for > pkg-config, and fails on distros that don't provide their own bzip2.pc >=20 > In general it's good to have. >=20 > And particularly, it makes it much easier to detect bzip2 as "a > dependency" instead of "manual linker flags" from the Meson build > system, which can then toggle between multiple "dependency" providers > via e.g. > = https://mesonbuild.com/Wrap-dependency-system-manual.html#provide-section >=20 The whole series looks great, thanks for doing this. Best, sam --Apple-Mail=_A17F91E5-46FB-4165-867C-2D2D6A862C71 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY1VlwV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kNLuAP9kWu/vs45FeZekh4E5NoaVI998unqYCzgrsyl1unvrZAEA/F8BazhEJPa1 yqW9nCLASX7/O0SVKKFON5GWBkkY2Qw= =19/L -----END PGP SIGNATURE----- --Apple-Mail=_A17F91E5-46FB-4165-867C-2D2D6A862C71--