From: Federico Mena Quintero <federico@gnome.org>
To: Mark Wielaard <mark@klomp.org>, bzip2-devel@sourceware.org
Cc: Julian Seward <jseward@acm.org>
Subject: Re: bzip2 1.0.7 released
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <8c4d5cf2479253406dacdee122692cc77771afb9.camel@gnome.org> (raw)
In-Reply-To: <0a2331bc6d0c8500c2c45df1e3ebe01b49ad5831.camel@klomp.org>
On Fri, 2019-06-28 at 00:46 +0200, Mark Wielaard wrote:
>
> So it looks like some implementations might add more selectors than
> necessary. For example lbzip2 seems to use a max of 18000 + 1 + 7.
> Which might explain why our 18002 = 2 + (900000 / 50) isn't enough,
> and
> why my random increase of 5 seemed to work for the given file.
>
> In general the nSelector field can be up to 15 bits, so 32768. So we
> definitely do want to check the input doesn't overflow (or make
> BZ_MAX_SELECTORS 32768, but that seems excessive).
I've posted a little more analysis here:
https://gitlab.com/federicomenaquintero/bzip2/issues/24
Federico
next prev parent reply other threads:[~2019-06-28 0:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Mark Wielaard
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Jeffrey Walton
2019-01-01 0:00 ` Federico Mena Quintero
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Federico Mena Quintero [this message]
2019-01-01 0:00 ` Julian Seward
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Federico Mena Quintero
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` bzip2 test suite (Was: bzip2 1.0.7 released) Mark Wielaard
2019-01-01 0:00 ` Alternative nSelectors patch " Mark Wielaard
2019-01-01 0:00 ` Julian Seward
2019-01-01 0:00 ` Mark Wielaard
2019-01-01 0:00 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c4d5cf2479253406dacdee122692cc77771afb9.camel@gnome.org \
--to=federico@gnome.org \
--cc=bzip2-devel@sourceware.org \
--cc=jseward@acm.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).