From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121131 invoked by alias); 28 Jun 2019 00:13:47 -0000 Mailing-List: contact bzip2-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Sender: bzip2-devel-owner@sourceware.org Received: (qmail 121121 invoked by uid 89); 28 Jun 2019 00:13:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,SPF_NEUTRAL autolearn=no version=3.3.1 spammy=HX-Languages-Length:666, our X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,SPF_NEUTRAL autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Message-ID: <8c4d5cf2479253406dacdee122692cc77771afb9.camel@gnome.org> Subject: Re: bzip2 1.0.7 released From: Federico Mena Quintero To: Mark Wielaard , bzip2-devel@sourceware.org Cc: Julian Seward Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <0a2331bc6d0c8500c2c45df1e3ebe01b49ad5831.camel@klomp.org> References: <20190627205837.GD9273@wildebeest.org> <0a2331bc6d0c8500c2c45df1e3ebe01b49ad5831.camel@klomp.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-q2/txt/msg00028.txt.bz2 On Fri, 2019-06-28 at 00:46 +0200, Mark Wielaard wrote: > > So it looks like some implementations might add more selectors than > necessary. For example lbzip2 seems to use a max of 18000 + 1 + 7. > Which might explain why our 18002 = 2 + (900000 / 50) isn't enough, > and > why my random increase of 5 seemed to work for the given file. > > In general the nSelector field can be up to 15 bits, so 32768. So we > definitely do want to check the input doesn't overflow (or make > BZ_MAX_SELECTORS 32768, but that seems excessive). I've posted a little more analysis here: https://gitlab.com/federicomenaquintero/bzip2/issues/24 Federico