public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: Jeffrey Walton <noloader@gmail.com>
To: bzip2-devel@sourceware.org
Subject: call to ‘fprintf’ from within signal handler [CWE-479]
Date: Thu, 16 Jul 2020 04:49:45 -0400	[thread overview]
Message-ID: <CAH8yC8m=SGOa=tHMh4giELb7nQJA+NtOtCNzXrM1L7wnePb5PQ@mail.gmail.com> (raw)

Hi Everyone,

I'm testing a build with the GCC 10 analyzer. Add -fanalyzer to
CFLAGS. If you need GCC 10, then you can find it on Fedora 32.

The Analyzer is producing a finding:

bzip2.c:677:4: warning: call to ‘fprintf’ from within signal handler
[CWE-479] [-Wanalyzer-unsafe-call-within-signal-handler]
  677 |    fprintf (
      |    ^~~~~~~~~
  678 |       stderr,
      |       ~~~~~~~
  679 |       "\tInput file = %s, output file = %s\n",
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  680 |       inName, outName
      |       ~~~~~~~~~~~~~~~
  681 |    );

There are two additional findings that are similar.

             reply	other threads:[~2020-07-16  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16  8:49 Jeffrey Walton [this message]
2020-07-16 13:55 ` Mark Wielaard
2020-07-16 15:03   ` Jeffrey Walton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH8yC8m=SGOa=tHMh4giELb7nQJA+NtOtCNzXrM1L7wnePb5PQ@mail.gmail.com' \
    --to=noloader@gmail.com \
    --cc=bzip2-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).