public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Carlo Bramini <carlo.bramix@libero.it>
Cc: "bzip2-devel@sourceware.org" <bzip2-devel@sourceware.org>
Subject: Re: Declare bzerrorstrings[] to be a const object.
Date: Tue, 26 Apr 2022 21:35:01 +0200	[thread overview]
Message-ID: <YmhJZdpiNFhxeM8r@wildebeest.org> (raw)
In-Reply-To: <434364370.952076.1650983602854@mail1.libero.it>

Hi,

On Tue, Apr 26, 2022 at 04:33:22PM +0200, Carlo Bramini via Bzip2-devel wrote:
> by looking the content of the map file, I discovered that bzerrorstrings[] is not const.

Which map file is this?

> So, I would like to suggest the tiny change into the attached patch, for declaring both bzerrorstrings[] and the addressed strings as const.
> The patch has been created from the latest sources into the repository with GIT.

Although the patch seems fine I must admit that I don't fully
understand why it is necessary. Isn't an array (name) not always
constant? You cannot assign anything to an array name since it is a
contant pointer to the first element. Or is that not what this "const"
is about?

Thanks,

Mark


  reply	other threads:[~2022-04-26 19:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 14:33 Carlo Bramini
2022-04-26 19:35 ` Mark Wielaard [this message]
2022-04-27  9:21   ` Carlo Bramini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmhJZdpiNFhxeM8r@wildebeest.org \
    --to=mark@klomp.org \
    --cc=bzip2-devel@sourceware.org \
    --cc=carlo.bramix@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).