public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Joshua Watt <JPEW.hacker@gmail.com>, bzip2-devel@sourceware.org
Subject: Re: [PATCH] Fix include path separator
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <b7bab17803f94426110244c1544c7ba2fb98b9dc.camel@klomp.org> (raw)
In-Reply-To: <20190702200544.27137-1-JPEW.hacker@gmail.com>

Hi Joshua,

On Tue, 2019-07-02 at 15:05 -0500, Joshua Watt wrote:
> Changes the include path separator for Windows builds to use "/" instead
> of "\". Windows has no problems with using a forward slash as a path
> separator, but using a backslash causes problems when attempting to
> cross compile for other platforms (for example, when trying to cross
> compile for MinGW from Linux).

Thanks for the patch.

I think this makes total sense. And I see something similar is already
on the 1.1.x branch. But I am slightly hesitant making any build
changes. Especially since we don't have any buildbots for Windows. And
I personally don't have any access to Windows.

Are you sure all Windows compilers accept the forward instead of
backwards slash for standard include statements?
Is there anything in the C standard that say a forward (or backwards)
slash should be accepted?

Sorry for being a little pedantic when it comes to build changes.

Thanks,

Mark

  reply	other threads:[~2019-07-03 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 Joshua Watt
2019-01-01  0:00 ` Mark Wielaard [this message]
     [not found]   ` <CAJdd5GZfTk8EKeUE_C1keKm+gn=qapv9OQGGariiiXP9jyu0wQ@mail.gmail.com>
2019-01-01  0:00     ` _stati64 patch (Was: [PATCH] Fix include path separator) Mark Wielaard
2019-01-01  0:00       ` Joshua Watt
2019-01-01  0:00         ` Mark Wielaard
2019-01-01  0:00           ` Joshua Watt
2019-01-01  0:00             ` Mark Wielaard
2019-01-01  0:00               ` Joshua Watt
2019-01-01  0:00                 ` Mark Wielaard
2019-01-01  0:00                   ` Joshua Watt
2019-01-01  0:00     ` [PATCH] Fix include path separator Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7bab17803f94426110244c1544c7ba2fb98b9dc.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=JPEW.hacker@gmail.com \
    --cc=bzip2-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).