From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10469 invoked by alias); 3 Jul 2019 19:04:21 -0000 Mailing-List: contact bzip2-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Sender: bzip2-devel-owner@sourceware.org Received: (qmail 10447 invoked by uid 89); 3 Jul 2019 19:04:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Message-ID: Subject: Re: [PATCH] Fix include path separator From: Mark Wielaard To: Joshua Watt , bzip2-devel@sourceware.org Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <20190702200544.27137-1-JPEW.hacker@gmail.com> References: <20190702200544.27137-1-JPEW.hacker@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-SW-Source: 2019-q3/txt/msg00009.txt.bz2 Hi Joshua, On Tue, 2019-07-02 at 15:05 -0500, Joshua Watt wrote: > Changes the include path separator for Windows builds to use "/" instead > of "\". Windows has no problems with using a forward slash as a path > separator, but using a backslash causes problems when attempting to > cross compile for other platforms (for example, when trying to cross > compile for MinGW from Linux). Thanks for the patch. I think this makes total sense. And I see something similar is already on the 1.1.x branch. But I am slightly hesitant making any build changes. Especially since we don't have any buildbots for Windows. And I personally don't have any access to Windows. Are you sure all Windows compilers accept the forward instead of backwards slash for standard include statements? Is there anything in the C standard that say a forward (or backwards) slash should be accepted? Sorry for being a little pedantic when it comes to build changes. Thanks, Mark