public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: "noloader at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: bzip2-devel@sourceware.org
Subject: [Bug bzip2/25513] New: Update Makefiles; add Makefile for Darwin
Date: Wed, 01 Jan 2020 00:00:00 -0000	[thread overview]
Message-ID: <bug-25513-11876@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=25513

            Bug ID: 25513
           Summary: Update Makefiles; add Makefile for Darwin
           Product: bzip2
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bzip2
          Assignee: nobody at sourceware dot org
          Reporter: noloader at gmail dot com
                CC: bzip2-devel at sourceware dot org
  Target Milestone: ---

Created attachment 12263
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12263&action=edit
Update Bzip2 makefiles for static archive and shared object. New makefile for
Darwin dylib

As [not] discussed on the mailing list :) There were no comments.

On Darwin the install_name libbz2.1.0.dylib was used.

---------- Forwarded message ---------
From: Jeffrey Walton <noloader@gmail.com>
Date: Sun, Feb 2, 2020 at 9:39 AM
Subject: Makefile for Darwin
To: <bzip2-devel@sourceware.org>

Hi Everyone,

Attached is a makefile for Darwin dylibs. The Darwin makefile is a lot
like the shared object makefile, so there is not much to explain. (In
fact, it was mostly a copy/paste). The Darwin makefile also sets
install_names before and after install. The makefile was tested on
modern OS X10.9 (x86_64 with clang) and OS X 10.5 (PowerMac with gcc).

The regular makefile and the shared object makefile are also included.
The makefiles were cleaned up to follow GNU Coding Standards. The
interesting sections of the manual are at [1][2][3].

Effectively it means standard variables were used so (1) the makefile
behaves like users expect, and (2) it is easier to for user's to
override default settings. For example, VPATHs are now supported by
using $< and $@ instead of hardcoding filenames.

Though the original makefiles were modified, all existing behavior is
preserved. Someone running 'make && make install' should see the same
behavior as before.

The open question (for me) on Darwin is, should the library use the
name libbz2.1.0.8.dylib. The name is consistent with Linux and Unix,
but I believe OS X typical uses Maj.Min numbers for this case, not
Maj.Min.Rev. That is, on OS X, libbz2.1.0.dylib would be more common.

If anyone has comments, then they would be appreciated.

I'll open a bug report with a pull request after comments. Or, if
Julian or Mark prefers, unzip in the bzip2 directory and simply check
them in. I don't care about credits or copyright or license.
Everything belongs to the project.

[1] https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html
[2] https://www.gnu.org/prep/standards/html_node/Directory-Variables.html
[3] https://www.gnu.org/prep/standards/html_node/Command-Variables.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2020-02-06  3:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01  0:00 noloader at gmail dot com [this message]
2020-01-01  0:00 ` [Bug bzip2/25513] " noloader at gmail dot com
2020-01-01  0:00 ` noloader at gmail dot com
2020-01-01  0:00 ` noloader at gmail dot com
2020-01-01  0:00 ` noloader at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25513-11876@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=bzip2-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).