From: Doug Evans <dje@transmeta.com>
To: Johan Rydberg <johan.rydberg@netinsight.se>
Cc: "Frank Ch. Eigler" <fche@redhat.com>, cgen@sources.redhat.com
Subject: Re: enums
Date: Wed, 06 Dec 2000 09:28:00 -0000 [thread overview]
Message-ID: <14894.30501.274454.390529@casey.transmeta.com> (raw)
In-Reply-To: <3A2E820B.F0173EC7@netinsight.se>
Johan Rydberg writes:
> Doug Evans wrote:
>
> > Take the line with () out.
>
> Well, it "works" (cgen doesn't complain that is) now. But the
> result int the "desc.h" file is still the same.
Righto. One more
(define-enum
(name e-exception)
(comment "exception vectors")
- ()
(prefix E_)
- (values ("RESET") ("BUSERR" -) ("DPF" -) ("IPF" -)
+ (values (("RESET") ("BUSERR" -) ("DPF" -) ("IPF" -)
("EXTINT" -) ("ALIGN" -) ("ILLEGAL" -) ("PEINT" -)
("DTLBMISS" -) ("ITLBMISS" -) ("RRANGE" -)
- ("SYSCALL" -) ("BREAK" -) ("RESERVED" -))
+ ("SYSCALL" -) ("BREAK" -) ("RESERVED" -)) )
)
I think I chose to require the extra parens in case I wanted to
add a new parameter. If y'all can't imagine anything
being added we can change things - without the parens is simpler.
[One can certainly argue cgen should prohibit extra args
to avoid breaking a port in the future if it should happen to have
junk there - the extra args are silently ignored now.
This gets back to being more robust with bad input.]
next prev parent reply other threads:[~2000-12-06 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-06 0:30 enums Johan Rydberg
2000-12-06 3:16 ` enums Frank Ch. Eigler
2000-12-06 3:23 ` enums Johan Rydberg
2000-12-06 3:35 ` enums Ben Elliston
2000-12-06 3:38 ` enums Johan Rydberg
2000-12-06 8:55 ` enums Doug Evans
2000-12-06 9:06 ` enums Johan Rydberg
2000-12-06 9:28 ` Doug Evans [this message]
2000-12-07 6:33 ` enums Johan Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14894.30501.274454.390529@casey.transmeta.com \
--to=dje@transmeta.com \
--cc=cgen@sources.redhat.com \
--cc=fche@redhat.com \
--cc=johan.rydberg@netinsight.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).