From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10182 invoked by alias); 1 Feb 2002 18:22:40 -0000 Mailing-List: contact cgen-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sources.redhat.com Received: (qmail 10118 invoked from network); 1 Feb 2002 18:22:39 -0000 Received: from unknown (HELO neon-gw.transmeta.com) (63.209.4.196) by sources.redhat.com with SMTP; 1 Feb 2002 18:22:39 -0000 Received: (from root@localhost) by neon-gw.transmeta.com (8.9.3/8.9.3) id KAA31509; Fri, 1 Feb 2002 10:22:35 -0800 Received: from mailhost.transmeta.com(10.1.1.15) by neon-gw.transmeta.com via smap (V2.1) id xma031497; Fri, 1 Feb 02 10:22:10 -0800 Received: from casey.transmeta.com (casey.transmeta.com [10.10.25.22]) by deepthought.transmeta.com (8.11.6/8.11.6) with ESMTP id g11IMDS29903; Fri, 1 Feb 2002 10:22:13 -0800 (PST) Received: (from dje@localhost) by casey.transmeta.com (8.9.3/8.7.3) id KAA01097; Fri, 1 Feb 2002 10:22:13 -0800 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15450.56533.178570.221510@casey.transmeta.com> Date: Fri, 01 Feb 2002 10:22:00 -0000 To: "Frank Ch. Eigler" Cc: binutils@sources.redhat.com, cgen@sources.redhat.com Subject: Re: include/dis-asm.h patch for cgen disassemblers In-Reply-To: <20020201131309.C2190@redhat.com> References: <20020131124350.C19966@redhat.com> <15449.42904.232177.265525@casey.transmeta.com> <20020131162132.I19966@redhat.com> <15449.47582.575411.945069@casey.transmeta.com> <20020201131309.C2190@redhat.com> X-Mailer: VM 6.72 under 21.1 (patch 8) "Bryce Canyon" XEmacs Lucid X-SW-Source: 2002-q1/txt/msg00037.txt.bz2 Frank Ch. Eigler writes: > A general hook is the "char* disassembler_options" field, which is used > as a catch-all. Where this field is used (arm, i386, ppc), it's almost > exclusively to encode the ISA selection. This is used to pass in disassembler options from the user too though, right? If so, it's definately not what you want here. > I'd prefer to formalize the > isa switch than continue to deformalize to a string option, especially > as isa switching is a correctness issue. (Some of these disassembleres > use the string also for rendering preferences.) As I said, I can't think of a better name. No more objections here.