PATCH: fix sim/i960/Makefile.in for CGEN

PATCH: fix sim/i960/Makefile.in for CGEN

[Greg McGary]

The `@true' commands defeat VPATH and render sim/i960 uncompilable
when $(srcdir) != $(builddir).  fr30 and m32r already have this fix,
though it's done by commenting-out the `@true' line (IMO, those should
be removed entirely).


2000-11-15  Greg McGary  <greg@mcgary.org>

	* Makefile.in: remove `@true' commands for rules that have
	$(CGEN_MAINT) as a prerequisite.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/sim/i960/Makefile.in,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile.in
--- Makefile.in	2000/08/21 15:52:39	1.2
+++ Makefile.in	2000/11/15 21:27:09
@@ -110,14 +110,12 @@ stamp-arch: $(CGEN_READ_SCM) $(CGEN_ARCH
 	  FLAGS="with-scache with-profile=fn"
 	touch stamp-arch
 arch.h arch.c cpuall.h: $(CGEN_MAINT) stamp-arch
-	@true
 
 stamp-cpu: $(CGEN_READ_SCM) $(CGEN_CPU_SCM) $(CGEN_DECODE_SCM) $(srccgen)/i960.cpu
 	$(MAKE) cgen-cpu-decode $(CGEN_FLAGS_TO_PASS) \
 	  cpu=i960base mach=i960:ka_sa,i960:ca SUFFIX= FLAGS="with-scache with-profile=fn" EXTRAFILES="$(CGEN_CPU_SEM) $(CGEN_CPU_SEMSW)"
 	touch stamp-cpu
 cpu.h sem.c sem-switch.c model.c decode.c decode.h: $(CGEN_MAINT) stamp-cpu
-	@true
 
 stamp-desc: $(CGEN_READ_SCM) $(CGEN_DESC_SCM) \
 		$(srccgen)/sparc.cpu $(srccgen)/sparccom.cpu $(srccgen)/i960.cpu $(srccgen)/i960.cpu
@@ -125,4 +123,3 @@ stamp-desc: $(CGEN_READ_SCM) $(CGEN_DESC
 		cpu=i960 mach=all
 	touch stamp-desc
 i960-desc.c i960-desc.h i960-opc.h: $(CGEN_MAINT) stamp-desc
-	@true

Re: PATCH: fix sim/i960/Makefile.in for CGEN

[Dave Brolley]

Greg McGary wrote:
> 
> The `@true' commands defeat VPATH and render sim/i960 uncompilable
> when $(srcdir) != $(builddir).  fr30 and m32r already have this fix,
> though it's done by commenting-out the `@true' line (IMO, those should
> be removed entirely).

Yeah -- I only commented them out because I wasn't sure it wasn't
some kind of bug in my version of make. What is @true supposed to
do anyway, and why does it mess up VPATH?

Dave

Re: PATCH: fix sim/i960/Makefile.in for CGEN

[Greg McGary]

Dave Brolley <brolley@redhat.com> writes:

> Yeah -- I only commented them out because I wasn't sure it wasn't
> some kind of bug in my version of make. What is @true supposed to
> do anyway, and why does it mess up VPATH?

As I understand it...

Without `@true', there are no commands, and the lines simply express
dependencies, with all filenames subject to modification by VPATH.

With `@true' as a command, they become rules which tell make how
to produce the targets in the current directory, so VPATH no longer
applies for those target files.

Greg