public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@transmeta.com>
To: Dave Brolley <brolley@redhat.com>
Cc: cgen@sources.redhat.com
Subject: Re: [patch][rfa] Ordering insns in hash chain for cgen disassemblers
Date: Thu, 15 Nov 2001 09:52:00 -0000	[thread overview]
Message-ID: <15348.168.750723.846784@casey.transmeta.com> (raw)
Message-ID: <20011115095200.dYhlv-yaoGvOhcvbCT-kPwFU6WTxtoUhCE5BSqXk5gA@z> (raw)
In-Reply-To: <3BF3F9AE.8070907@redhat.com>

Dave Brolley writes:
 > Doug Evans wrote:
 > >Setting aside the state of the implementation of ifield assertions
 > >(since I don't remember what it is), why wouldn't an ifield assertion
 > >work here?
 > >
 > Yes, I specified them fully and found that they are ignored  :-(

Then a todo item (I saw a mention of this in the docs).  Wanna do it?
That's a more preferable patch than the current one (I think!).

I'm not going to argue for it's removal but fwiw it slightly bothers me.
I worry it's just going to cause headaches.
[While not being the only cause of the worry, question: how will this
sort play with ifield assertion support when it's added, and the
user's expectation that things are picked based on order in the file.
Maybe you could choose to not sort insns with ifield assertions, I guess.
But then things would be getting a bit convoluted.]

 > >(or see the static fn decls at the top of cgen-dis.c)
 > >
 > That was there already.

No claim was made that you had written it (though I can see that
one might infer that), and yes I realize it was there already.

  reply	other threads:[~2001-11-15  9:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-05 13:20 Dave Brolley
2001-10-09 12:09 ` [patch][rfa] Ordering insns in hash chain for cgen disassemblers -- committed Dave Brolley
2001-11-14 12:09   ` Dave Brolley
2001-10-09 16:29 ` [patch][rfa] Ordering insns in hash chain for cgen disassemblers Doug Evans
2001-10-10  2:11   ` Dave Brolley
2001-10-10  3:33     ` Doug Evans [this message]
2001-10-10  6:33       ` Dave Brolley
2001-11-15 10:11         ` Dave Brolley
2001-11-15  9:52       ` Doug Evans
     [not found]     ` <15348.168.750723.846784.cygnus.local.cgen@casey.transmeta.com>
2001-10-13  2:39       ` Frank Ch. Eigler
2001-11-15 12:42         ` Frank Ch. Eigler
2001-11-15  9:21     ` Dave Brolley
2001-11-14 12:52   ` Doug Evans
2001-11-13 11:46 ` Dave Brolley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15348.168.750723.846784@casey.transmeta.com \
    --to=dje@transmeta.com \
    --cc=brolley@redhat.com \
    --cc=cgen@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).