From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31881 invoked by alias); 7 Aug 2003 00:44:29 -0000 Mailing-List: contact cgen-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sources.redhat.com Received: (qmail 31861 invoked from network); 7 Aug 2003 00:44:27 -0000 Received: from unknown (HELO tiktok.the-meissners.org) (66.205.90.83) by sources.redhat.com with SMTP; 7 Aug 2003 00:44:27 -0000 Received: from tiktok.the-meissners.org (localhost [127.0.0.1]) by tiktok.the-meissners.org (8.12.8/8.12.8) with ESMTP id h770iRrn031612; Wed, 6 Aug 2003 20:44:27 -0400 Received: (from meissner@localhost) by tiktok.the-meissners.org (8.12.8/8.12.8/Submit) id h770iQDX031610; Wed, 6 Aug 2003 20:44:26 -0400 Date: Thu, 07 Aug 2003 13:52:00 -0000 From: Michael Meissner To: binutils@sources.redhat.com, cgen@sources.redhat.com Subject: Re: Patches to move cgen files to C90 with prototypes Message-ID: <20030807004426.GA31603@tiktok.the-meissners.org> Mail-Followup-To: Michael Meissner , binutils@sources.redhat.com, cgen@sources.redhat.com References: <20030807001021.GA31218@tiktok.the-meissners.org> <16177.39941.684697.94934@casey.transmeta.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16177.39941.684697.94934@casey.transmeta.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-q3/txt/msg00035.txt.bz2 On Wed, Aug 06, 2003 at 05:23:33PM -0700, Doug Evans wrote: > Michael Meissner writes: > > 2003-08-06 Michael Meissner > > > > ... massively large changelog entry, > > ... especially for just a k&r -> c90 substitution > > fwiw, I think people think they're under far too much pressure to > write anally correct changelog entries before a patch will get accepted. I don't care one way or another, as I can rewrite it however people want. I do recall it came up in GCC about a year ago, with people complaining that they wanted to be able to grep for each function modified, and in particular didn't want things like: * ({put,get}_some_function): Blah, blah, blah. > Nick, in this particular case, does one really have to mention every function? > How about this instead? > > 2003-08-06 Michael Meissner > > * cgen-dis.in (*): Remove PARAMS macro. Use void * instead of PTR. > * cgen-ibld.in (*): Ditto. > * cgen-asm.in (*): Ditto. > * cgen-dis.c (*): Ditto. > * cgen-opc.c (*): Ditto. > * cgen-asm.c (*): Ditto. I probably would do it as: * cgen-dis.in: Remove PARAMS macro. Use void * instead of PTR. Fully prototype all function definitions. * cgen-ibld.in: Ditto. ... ie, drop the (*). > [N.B. I said "in this particular case". Don't try to generalize > my comments too far ...] -- Michael Meissner email: gnu@the-meissners.org http://www.the-meissners.org