From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30644 invoked by alias); 8 Aug 2003 12:15:32 -0000 Mailing-List: contact cgen-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sources.redhat.com Received: (qmail 30629 invoked from network); 8 Aug 2003 12:15:30 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 8 Aug 2003 12:15:30 -0000 Received: from tooth.toronto.redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 0F2C080004A; Fri, 8 Aug 2003 08:15:30 -0400 (EDT) Received: from tooth.toronto.redhat.com (IDENT:u5VBNTr4hjdsn/9Q70pwFa6XizWvyvRL@localhost [127.0.0.1]) by tooth.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id h78CFTVm006504; Fri, 8 Aug 2003 08:15:29 -0400 Received: (from fche@localhost) by tooth.toronto.redhat.com (8.12.8/8.12.8/Submit) id h78CFTPJ006501; Fri, 8 Aug 2003 08:15:29 -0400 Date: Fri, 08 Aug 2003 12:54:00 -0000 From: "Frank Ch. Eigler" To: Nick Clifton Cc: binutils@sources.redhat.com, cgen@sources.redhat.com Subject: Re: Patches to move cgen files to C90 with prototypes Message-ID: <20030808121529.GB27175@redhat.com> References: <20030807001021.GA31218@tiktok.the-meissners.org> <16177.39941.684697.94934@casey.transmeta.com> <20030807004426.GA31603@tiktok.the-meissners.org> <20030808092618.GP27145@bubble.sa.bigpond.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SW-Source: 2003-q3/txt/msg00044.txt.bz2 Hi - On Fri, Aug 08, 2003 at 12:42:30PM +0100, Nick Clifton wrote: > [...] > > Do you reckon anyone is going to be interested in something as > > trivial as a conversion to C90? > > Yes. The conversion might possibly introduce a bug. Or someone might > want to get hold of the latest version of the function prior to its > conversion to C90. Given that such mechanical conversions end up being done en-masse for all the functions in a given file, anyone wanting to know those things could find the single line * file.c: c90-ized. and understand. Would you be of the same opinion if someone checked in, say, code that's reformatted with the most fashionable indent settings? > Or, there could be any number of reasons. Perhaps. > Including the function names in the ChangeLog entry when doing these > conversions is tedious but it is not that hard to do so I think that > it is worthwhile. On the downside, it renders the ChangeLog so tediously verbose that manual browsing is frustrated. People not only search through ChangeLog files for functions of interest. They sometimes want to scan it top to bottom. - FChE