From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
To: cgen@sourceware.org
Cc: Alan Modra <amodra@gmail.com>,
fche@sourceware.org, Christian Svensson <blue@cmd.nu>,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
"Maciej W. Rozycki" <macro@codesourcery.com>
Subject: [PATCH] Make large enum constants unsigned
Date: Thu, 22 May 2014 05:30:00 -0000 [thread overview]
Message-ID: <20140522052921.GA30609@chokladfabriken.org> (raw)
Hi,
this fixes a bug noted in two threads on the binutils mailing list:
https://sourceware.org/ml/binutils/2014-05/msg00152.html
https://sourceware.org/ml/binutils/2014-05/msg00195.html
Both threads describe the problem pretty well, but the gist of it
is that constants are generated that will be interpreted as signed.
2014-05-22 Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
* enum.scm (gen-enum-decl): Emit 'ULL' after constants larger than
#x80000000
Index: cgen/enum.scm
===================================================================
RCS file: /cvs/src/src/cgen/enum.scm,v
retrieving revision 1.13
diff -u -r1.13 enum.scm
--- cgen/enum.scm 13 Feb 2010 03:39:15 -0000 1.13
+++ cgen/enum.scm 22 May 2014 05:23:23 -0000
@@ -298,7 +298,10 @@
""
(string-append " = "
(if (number? (cadr e))
- (number->string (cadr e))
+ (string-append (number->string (cadr e))
+ (if (> (cadr e)
+ #x80000000)
+ "ULL" ""))
(cadr e))))
))
(if (and san? include-sanitize-marker?)
next reply other threads:[~2014-05-22 5:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 5:30 Stefan Kristiansson [this message]
2014-05-22 6:22 ` Maciej W. Rozycki
2014-05-22 6:52 ` Stefan Kristiansson
2014-05-22 7:10 ` Stefan Kristiansson
2014-05-22 13:33 ` Pierre Muller
[not found] ` <5561926758764771034@unknownmsgid>
2014-05-22 14:10 ` Stefan Kristiansson
2014-05-22 16:14 ` Maciej W. Rozycki
2014-05-22 15:11 ` Frank Ch. Eigler
2014-05-22 17:34 ` Stefan Kristiansson
2014-05-22 21:06 ` Frank Ch. Eigler
2014-05-22 21:42 ` Maciej W. Rozycki
2014-05-22 22:20 ` Frank Ch. Eigler
2014-05-29 20:09 ` Stefan Kristiansson
2014-05-29 20:32 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522052921.GA30609@chokladfabriken.org \
--to=stefan.kristiansson@saunalahti.fi \
--cc=amodra@gmail.com \
--cc=blue@cmd.nu \
--cc=cgen@sourceware.org \
--cc=fche@sourceware.org \
--cc=macro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).