From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cgen-return-2600-listarch-cgen=sources.redhat.com@sourceware.org>
Received: (qmail 12651 invoked by alias); 22 May 2014 21:06:48 -0000
Mailing-List: contact cgen-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <cgen.sourceware.org>
List-Subscribe: <mailto:cgen-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/cgen/>
List-Post: <mailto:cgen@sourceware.org>
List-Help: <mailto:cgen-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: cgen-owner@sourceware.org
Received: (qmail 12629 invoked by uid 89); 22 May 2014 21:06:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: elastic.org
Received: from elastic.org (HELO elastic.org) (69.20.226.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 May 2014 21:06:46 +0000
Received: from super.elastic.org (localhost [127.0.0.1])	by elastic.org (8.14.7/8.14.7) with ESMTP id s4ML6Ma9010399        (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);        Thu, 22 May 2014 17:06:22 -0400
Received: (from fche@localhost)	by super.elastic.org (8.14.7/8.14.7/Submit) id s4ML6LxV010398;	Thu, 22 May 2014 17:06:21 -0400
Date: Thu, 22 May 2014 21:06:00 -0000
From: "Frank Ch. Eigler" <fche@elastic.org>
To: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: cgen@sourceware.org, Alan Modra <amodra@gmail.com>, fche@sourceware.org,        Christian Svensson <blue@cmd.nu>,        Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,        "Maciej W. Rozycki" <macro@codesourcery.com>
Subject: Re: [PATCH] Make large enum constants unsigned
Message-ID: <20140522210621.GF4031@elastic.org>
References: <20140522052921.GA30609@chokladfabriken.org> <20140522150956.GC4031@elastic.org> <CADzBsGN3U6a3BS5L7o7DYh_4KTghEXnB2UE0XKdNZrAN=A0p=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADzBsGN3U6a3BS5L7o7DYh_4KTghEXnB2UE0XKdNZrAN=A0p=g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SW-Source: 2014-q2/txt/msg00014.txt.bz2

Hi -

> >      (string-append "(signed int)" (number->string (cadr e)))
> [...]
> how would that be better than?
>       (string-append (number->string (cadr e)) "U")

It would be a closer match to expressing our desire to match C enum
typing, but I'd be fine with "U" suffixing too.


> I dismissed that, since it would create a lot larger diff in generated
> files than in the isolated cases where it's actually a problem. [...]

IMHO, that's not such a big deal.  We don't usually look closely at
the diffs of generated files, once the generating tools are trustworthy.


- FChE