From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99238 invoked by alias); 14 Apr 2016 14:44:35 -0000 Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org Received: (qmail 99228 invoked by uid 89); 14 Apr 2016 14:44:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*cgen X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Apr 2016 14:44:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2ECE41A0EC9; Thu, 14 Apr 2016 14:44:32 +0000 (UTC) Received: from fche.csb (vpn-49-20.rdu2.redhat.com [10.10.49.20]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3EEiVNs013591; Thu, 14 Apr 2016 10:44:32 -0400 Received: by fche.csb (Postfix, from userid 2569) id 4447C584E5; Thu, 14 Apr 2016 10:44:31 -0400 (EDT) Date: Thu, 14 Apr 2016 14:44:00 -0000 From: "Frank Ch. Eigler" To: Trevor Saunders Cc: cgen@sourceware.org Subject: Re: (patch) stop generating code that uses old style arguments Message-ID: <20160414144431.GC30950@redhat.com> References: <20160414144606.GB9695@ball> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160414144606.GB9695@ball> User-Agent: Mutt/1.4.2.2i X-IsSubscribed: yes X-SW-Source: 2016-q2/txt/msg00002.txt.bz2 Hi - > I wanted to enable -Wold-style-{declaration,definition} for all of > binutils, and ran into cgen generating that style of definition, so > here's a patch to fix that. Looks good; are you able to commit? - FChE