From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105940 invoked by alias); 29 Oct 2018 13:34:36 -0000 Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org Received: (qmail 105896 invoked by uid 89); 29 Oct 2018 13:34:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=dni, HX-Received:sk:33-v6mr, 2014, H*r:sk:cgen@so X-HELO: mail-pl1-f195.google.com Received: from mail-pl1-f195.google.com (HELO mail-pl1-f195.google.com) (209.85.214.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Oct 2018 13:34:29 +0000 Received: by mail-pl1-f195.google.com with SMTP id t6-v6so3808896plo.9 for ; Mon, 29 Oct 2018 06:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JbxeUM5tfstYojd4M2JgaenVl9FQ5ZbiOqN43TtfKcM=; b=Yq4rJ2jP5kICixEp6lZoSaezE/gnwgH2JmiNL4dp/SwyHIHje4qsZvCmmGR0axfowJ B60g8ICOrEVmKXV/jSLQRMqoJVfj8erRXowNQGnVYvV1BVYmK1K3D1WplNwIa7C4cv+f gZNMRaH3Y2XuPEfmocTTPb9bFk8My6Rf5+LAb9C5G9wa2o8aqa+8MTYF9+uEWlx6Qn93 kei6MUpUebteWMmTIIB+RqEd9Pw7qWgGrO3/WpcTZe/sY6KcAETe0E/M2++gnnTNijZm 8kzWizMU0RxHZ7EUtf6jZZbJRkCM7aEjZAqC7D3Cta21dpDhsob+9WD/x2NgSWE+b5hH dWXg== Return-Path: Received: from localhost (g148.61-193-223.ppp.wakwak.ne.jp. [61.193.223.148]) by smtp.gmail.com with ESMTPSA id w66-v6sm26351997pfb.51.2018.10.29.06.34.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 06:34:27 -0700 (PDT) Date: Mon, 29 Oct 2018 13:34:00 -0000 From: Stafford Horne To: Richard Henderson Cc: Segher Boessenkool , GCC patches , Openrisc , Jeff Law , Joseph Myers , Joel Sherrill , Sebastian Huber , cgen@sourceware.org Subject: Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc Message-ID: <20181029133425.GE1761@lianli.shorne-pla.net> References: <20181027043702.18414-1-shorne@gmail.com> <20181027043702.18414-4-shorne@gmail.com> <20181028025730.GH5766@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2018-q4/txt/msg00001.txt.bz2 On Sun, Oct 28, 2018 at 11:16:13PM +0000, Richard Henderson wrote: > On 10/28/18 2:57 AM, Segher Boessenkool wrote: > >> +(define_insn "xorsi3" > >> + [(set (match_operand:SI 0 "register_operand" "=r,r") > >> + (xor:SI > >> + (match_operand:SI 1 "register_operand" "%r,r") > >> + (match_operand:SI 2 "reg_or_s16_operand" " r,I")))] > >> + "" > >> + "@ > >> + l.xor\t%0, %1, %2 > >> + l.xori\t%0, %1, %2") > > > > Is this correct? Should this be unsigned (u16 and K)? > > No, l.xori is signed. Right, sorry, I didn't have enough time to look at this at all this morning. It is correct. It looks like the documentation for this page [1] is generated from the cgen cpu descriptions that were removed from binutils-gdb back in 2014. Ccing cgen who seem to maintain this web page. How can we go about getting it regenerated? cpu/or1korbis.cpu (alu-insn-uimm and) (alu-insn-uimm or) (alu-insn-simm xor) (define-pmacro (alu-carry-insn-simm mnemonic) (begin (dni (.sym l- mnemonic "i") (.str "l." mnemonic "i reg/reg/simm16") ((MACH ORBIS-MACHS)) (.str "l." mnemonic "i $rD,$rA,$simm16") (+ (.sym OPC_ (.upcase mnemonic) "I") rD rA simm16) [1] https://sourceware.org/cgen/gen-doc/openrisc-insn.html#insns -Stafford