public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
       [not found]     ` <ed59f12b-a2a3-fa28-0d03-de1d11bb6e42@twiddle.net>
@ 2018-10-29 13:34       ` Stafford Horne
  2018-10-29 16:35         ` Segher Boessenkool
  0 siblings, 1 reply; 5+ messages in thread
From: Stafford Horne @ 2018-10-29 13:34 UTC (permalink / raw)
  To: Richard Henderson
  Cc: Segher Boessenkool, GCC patches, Openrisc, Jeff Law,
	Joseph Myers, Joel Sherrill, Sebastian Huber, cgen

On Sun, Oct 28, 2018 at 11:16:13PM +0000, Richard Henderson wrote:
> On 10/28/18 2:57 AM, Segher Boessenkool wrote:
> >> +(define_insn "xorsi3"
> >> +  [(set (match_operand:SI 0 "register_operand" "=r,r")
> >> +	  (xor:SI
> >> +	   (match_operand:SI 1 "register_operand"   "%r,r")
> >> +	   (match_operand:SI 2 "reg_or_s16_operand" " r,I")))]
> >> +  ""
> >> +  "@
> >> +  l.xor\t%0, %1, %2
> >> +  l.xori\t%0, %1, %2")
> > 
> > Is this correct?  Should this be unsigned (u16 and K)?
> 
> No, l.xori is signed.

Right, sorry, I didn't have enough time to look at this at all this morning.  It
is correct.

It looks like the documentation for this page [1] is generated from the cgen cpu
descriptions that were removed from binutils-gdb back in 2014.  Ccing cgen who
seem to maintain this web page.  How can we go about getting it regenerated?

cpu/or1korbis.cpu

    (alu-insn-uimm and)
    (alu-insn-uimm or)
    (alu-insn-simm xor)

    (define-pmacro (alu-carry-insn-simm mnemonic)
      (begin
	(dni (.sym l- mnemonic "i")
	     (.str "l." mnemonic "i reg/reg/simm16")
	     ((MACH ORBIS-MACHS))
	     (.str "l." mnemonic "i $rD,$rA,$simm16")
	     (+ (.sym OPC_ (.upcase mnemonic) "I") rD rA simm16)

[1] https://sourceware.org/cgen/gen-doc/openrisc-insn.html#insns

-Stafford

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
  2018-10-29 13:34       ` [PATCH v3 3/3] or1k: gcc: initial support for openrisc Stafford Horne
@ 2018-10-29 16:35         ` Segher Boessenkool
  2018-10-29 16:42           ` Richard Henderson
  0 siblings, 1 reply; 5+ messages in thread
From: Segher Boessenkool @ 2018-10-29 16:35 UTC (permalink / raw)
  To: Stafford Horne
  Cc: Richard Henderson, GCC patches, Openrisc, Jeff Law, Joseph Myers,
	Joel Sherrill, Sebastian Huber, cgen

On Mon, Oct 29, 2018 at 10:34:25PM +0900, Stafford Horne wrote:
> On Sun, Oct 28, 2018 at 11:16:13PM +0000, Richard Henderson wrote:
> > On 10/28/18 2:57 AM, Segher Boessenkool wrote:
> > > Is this correct?  Should this be unsigned (u16 and K)?
> > 
> > No, l.xori is signed.
> 
> Right, sorry, I didn't have enough time to look at this at all this morning.  It
> is correct.
> 
> It looks like the documentation for this page [1] is generated from the cgen cpu
> descriptions that were removed from binutils-gdb back in 2014.  Ccing cgen who
> seem to maintain this web page.  How can we go about getting it regenerated?

Is there some better documentation available?  This is what google found
for me.  I would have like better docs (more compact, etc.)  Links to
such would be great to have in readings.html :-)


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
  2018-10-29 16:35         ` Segher Boessenkool
@ 2018-10-29 16:42           ` Richard Henderson
  2018-10-30 11:26             ` Stafford Horne
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Henderson @ 2018-10-29 16:42 UTC (permalink / raw)
  To: Segher Boessenkool, Stafford Horne
  Cc: GCC patches, Openrisc, Jeff Law, Joseph Myers, Joel Sherrill,
	Sebastian Huber, cgen

On 10/29/18 4:34 PM, Segher Boessenkool wrote:
> Is there some better documentation available?  This is what google found
> for me.  I would have like better docs (more compact, etc.)  Links to
> such would be great to have in readings.html :-)

https://openrisc.io/architecture

and especially the v1.2 pdf linked from there

https://raw.githubusercontent.com/openrisc/doc/master/openrisc-arch-1.2-rev0.pdf


r~

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
  2018-10-29 16:42           ` Richard Henderson
@ 2018-10-30 11:26             ` Stafford Horne
  2018-10-30 15:42               ` Segher Boessenkool
  0 siblings, 1 reply; 5+ messages in thread
From: Stafford Horne @ 2018-10-30 11:26 UTC (permalink / raw)
  To: Richard Henderson
  Cc: Segher Boessenkool, GCC patches, Openrisc, Jeff Law,
	Joseph Myers, Joel Sherrill, Sebastian Huber, cgen

On Mon, Oct 29, 2018 at 04:42:43PM +0000, Richard Henderson wrote:
> On 10/29/18 4:34 PM, Segher Boessenkool wrote:
> > Is there some better documentation available?  This is what google found
> > for me.  I would have like better docs (more compact, etc.)  Links to
> > such would be great to have in readings.html :-)
> 
> https://openrisc.io/architecture
> 
> and especially the v1.2 pdf linked from there
> 
> https://raw.githubusercontent.com/openrisc/doc/master/openrisc-arch-1.2-rev0.pdf

Thanks,

I meant to point this out during my previous reply.  Also, I will send a patch
for adding this to wwwdocs.

  https://www.gnu.org/software/gcc/readings.html

-Stafford

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
  2018-10-30 11:26             ` Stafford Horne
@ 2018-10-30 15:42               ` Segher Boessenkool
  0 siblings, 0 replies; 5+ messages in thread
From: Segher Boessenkool @ 2018-10-30 15:42 UTC (permalink / raw)
  To: Stafford Horne
  Cc: Richard Henderson, GCC patches, Openrisc, Jeff Law, Joseph Myers,
	Joel Sherrill, Sebastian Huber, cgen

On Tue, Oct 30, 2018 at 08:26:00PM +0900, Stafford Horne wrote:
> On Mon, Oct 29, 2018 at 04:42:43PM +0000, Richard Henderson wrote:
> > On 10/29/18 4:34 PM, Segher Boessenkool wrote:
> > > Is there some better documentation available?  This is what google found
> > > for me.  I would have like better docs (more compact, etc.)  Links to
> > > such would be great to have in readings.html :-)
> > 
> > https://openrisc.io/architecture
> > 
> > and especially the v1.2 pdf linked from there
> > 
> > https://raw.githubusercontent.com/openrisc/doc/master/openrisc-arch-1.2-rev0.pdf
> 
> Thanks,
> 
> I meant to point this out during my previous reply.  Also, I will send a patch
> for adding this to wwwdocs.
> 
>   https://www.gnu.org/software/gcc/readings.html

I figure out how I most likely found the out-of-date page btw: I googled
"openrisc xori" (no quotes).


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-10-30 15:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20181027043702.18414-1-shorne@gmail.com>
     [not found] ` <20181027043702.18414-4-shorne@gmail.com>
     [not found]   ` <20181028025730.GH5766@gate.crashing.org>
     [not found]     ` <ed59f12b-a2a3-fa28-0d03-de1d11bb6e42@twiddle.net>
2018-10-29 13:34       ` [PATCH v3 3/3] or1k: gcc: initial support for openrisc Stafford Horne
2018-10-29 16:35         ` Segher Boessenkool
2018-10-29 16:42           ` Richard Henderson
2018-10-30 11:26             ` Stafford Horne
2018-10-30 15:42               ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).