From: "Frank Ch. Eigler" <fche@redhat.com>
To: Guillermo Martinez <guillermo.e.martinez@oracle.com>
Cc: "cgen@sourceware.org" <cgen@sourceware.org>
Subject: Re: [PATCH CGEN v1] cgen: Compute correct mask and values when offset in define-ifield is not 0.
Date: Thu, 9 Sep 2021 21:23:21 -0400 [thread overview]
Message-ID: <20210910012321.GA19490@redhat.com> (raw)
In-Reply-To: <7123187.iIbC2pHGDl@sali>
Hi -
> Just to know if you have some comments to this patch :-)
> Thanks in advance.
Sorry, no fresh enough knowledge to offer informed commentary. If
your regression tests on other platform indicated no problems, and
it solves a real problem with your arch, go for it.
- FChE
next prev parent reply other threads:[~2021-09-10 1:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 2:32 Guillermo E. Martinez
2021-09-02 13:22 ` Guillermo Martinez
2021-09-10 1:23 ` Frank Ch. Eigler [this message]
2021-09-10 2:29 ` Jose E. Marchesi
2021-09-10 2:36 ` Jose E. Marchesi
2021-09-14 21:34 ` Jose E. Marchesi
2021-09-15 16:32 ` [PATCH v2] " Guillermo E. Martinez
2021-09-15 16:49 ` Jose E. Marchesi
2021-09-15 18:04 ` Guillermo Martinez
2021-11-25 23:02 ` Alan Modra
2021-11-25 23:28 ` Guillermo Martinez
2021-11-26 0:46 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910012321.GA19490@redhat.com \
--to=fche@redhat.com \
--cc=cgen@sourceware.org \
--cc=guillermo.e.martinez@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).