From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 16BDD3858C2C for ; Fri, 10 Sep 2021 01:23:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16BDD3858C2C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-600-2MlJz0klO8e9QCenyNPGzQ-1; Thu, 09 Sep 2021 21:23:23 -0400 X-MC-Unique: 2MlJz0klO8e9QCenyNPGzQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D10F0802937; Fri, 10 Sep 2021 01:23:22 +0000 (UTC) Received: from redhat.com (ovpn-112-63.phx2.redhat.com [10.3.112.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6C806D980; Fri, 10 Sep 2021 01:23:22 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1mOVGD-00057M-CS; Thu, 09 Sep 2021 21:23:21 -0400 Date: Thu, 9 Sep 2021 21:23:21 -0400 From: "Frank Ch. Eigler" To: Guillermo Martinez Cc: "cgen@sourceware.org" Subject: Re: [PATCH CGEN v1] cgen: Compute correct mask and values when offset in define-ifield is not 0. Message-ID: <20210910012321.GA19490@redhat.com> References: <20210820023254.2575757-1-guillermo.e.martinez@oracle.com> <7123187.iIbC2pHGDl@sali> MIME-Version: 1.0 In-Reply-To: <7123187.iIbC2pHGDl@sali> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cgen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cgen mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 01:23:28 -0000 Hi - > Just to know if you have some comments to this patch :-) > Thanks in advance. Sorry, no fresh enough knowledge to offer informed commentary. If your regression tests on other platform indicated no problems, and it solves a real problem with your arch, go for it. - FChE