From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 951883858D39 for ; Sun, 14 Nov 2021 18:34:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 951883858D39 Received: by mail-wr1-x431.google.com with SMTP id s13so26135053wrb.3 for ; Sun, 14 Nov 2021 10:34:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hHvedTf7wOXv1F0MKn+Qc+U6rvEGZr5w7udeaxD+cAs=; b=hZtiRWssnE+uPg0pEUrCFoKPcKdUVvejc7MTM9mJnhDPqxP9n0G0JyWywsk+LQrjHc +HBTSGiglKVVYwBaZUaqfYGrUKbcxzYXT5zjUfNYPFeqt4yt6wJRlYesvMVp7gRhMEEH vGj2sahLnmrmnRuM75+Ko/HSpzUy8kRSkYkfU/1nRqYuq6dkILGNfc6sjgn+1Ylbo1P/ DCYcr7BVUWMI2uR1CqFPk/E5iKPmg0zeePby74V8Yuz2HfEe7HTXYM4iNXjPa3lYolNC x/RjQVEMGxkXmuYdteqkwVkad4lqHFQzzOn7EwG3Ruw1cMP40Mtxbg1ORrqbQziTYQIA RvCg== X-Gm-Message-State: AOAM5339+3NTR/wFqIMbpz99+EfAzRkI9Z5qckWw4znWHnJwlX4frs0W d+dBULmnPANec79uNkj4W34= X-Google-Smtp-Source: ABdhPJyaOqZHb6yjhUJPbWfUGWqTW75ZJxlU6K/He01/y2hgP1diiDUYeLn4P2McqvO8IPNDwqYoMw== X-Received: by 2002:a5d:624f:: with SMTP id m15mr27931152wrv.13.1636914855769; Sun, 14 Nov 2021 10:34:15 -0800 (PST) Received: from nz (host81-147-8-167.range81-147.btcentralplus.com. [81.147.8.167]) by smtp.gmail.com with ESMTPSA id n8sm11825678wrp.95.2021.11.14.10.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Nov 2021 10:34:15 -0800 (PST) Date: Sun, 14 Nov 2021 18:34:14 +0000 From: Sergei Trofimovich To: Mike Frysinger Cc: cgen@sourceware.org, Sergei Trofimovich Subject: Re: [PATCH] cr16: fix build on gcc-12 (NULL comparison) Message-ID: <20211114183400.31449948@nz> In-Reply-To: References: <20211114174241.2955314-1-slyich@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cgen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cgen mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Nov 2021 18:34:17 -0000 On Sun, 14 Nov 2021 13:13:54 -0500 Mike Frysinger wrote: > On 14 Nov 2021 17:42, Sergei Trofimovich via Cgen wrote: > > From: Sergei Trofimovich > > > > On gcc-12 build fails as: > > > > sim/cr16/interp.c: In function 'lookup_hash': > > sim/cr16/interp.c:89:25: error: > > the comparison will always evaluate as 'true' > > for the address of 'mnimonic' will never be NULL [-Werror=address] > > 89 | if ((h->ops->mnimonic != NULL) && > > | ^~ > > > > 'mnimonic' is a sharr array within ops. It can never be NULL. > > > > While at it renamed 'mnimonic' to 'mnemonic'. > > --- > > sim/cr16/cr16_sim.h | 2 +- > > sim/cr16/interp.c | 5 ++--- > > 2 files changed, 3 insertions(+), 4 deletions(-) > > this code doesn't exist in cgen. did you mean to send the patch here ? > -mike My fault of not being able to read binutils-gdb/MAINTAINERS file. I somehow read 'cgen/; cgen parts of opcodes/, sim/' as "all of sim/" goes here. Will resend to gdb-patches@sourceware.org. Thank you! -- Sergei