From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 08F3E3858D28; Fri, 6 Jan 2023 07:59:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08F3E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3061Z0IE006845; Fri, 6 Jan 2023 07:59:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=corp-2022-7-12; bh=tv1/lg+fS5uRZLHFTJSqme894BakibugG9if2V9GyIo=; b=K/xeiuKAdf/dyXDk8y28eQpIilDu5GQCheL4PMb0n4JG8MpIIno55DwBx9k4sqZT4Dt9 qb9HSU0ygHBJNg72TDOWW/DUgf8YLMpxPuiIXkWAh4R1cS4q6EfAKN13107G/yXXyUuY Jl43id5+P/Sfc8/wwClkH4eLpjSy7MYNqSTCt+KHvDfh9XLqMjh2OD48bkWT0BhS0iXu gO6L4pZ/pgqbb4NsgBdVKVkozO/HTeEojx+9Eah4lR8Xj8kAN5g40AvIMIpg+bRfYap2 Yi/Rgq7DmdzDie1luFKopEWU738fyv8B0ghdr4NbYNQVR40QIsMb1UhD5egJZFhk6TYC Fg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtbgqtkg9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Jan 2023 07:59:35 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 3067uF4B027269; Fri, 6 Jan 2023 07:59:34 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mwdtt6rqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Jan 2023 07:59:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RrxaBWvQY4gV92B/O6mGYC1GOgOCoa8Qqi1sCBiRtCOEyctIXAMGzfiHC+1dOzL7Njb9h9sIlhURCXvXval8VvB38CyH+sTXBFWOoEGsa52OvUUuE6xTanFUlxEev2OmKZYipnPeRU9hN+5TGUu9tXmVpeOzTO0WIYSYLNSjRJS8NwMJbEEK/KeQBDpS0nTLhnXjS/giV5drSxrh8yJa9kMTS4s5GpyP9gjT83auA/5hvnoz+3Sj+6aOWvWnsV26LHOKDSeeg7CFAgxRrbzY26aHHB9WMzQASlX6ChpxKpi/6Z68guIkYdYOz753qkrPF83YWNl4es9sYxnym9ONMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tv1/lg+fS5uRZLHFTJSqme894BakibugG9if2V9GyIo=; b=iGRLvYDuEJ83aJUjLg4Du7hugKwkHuOysMCRDbzLHVKDcFg691vveRLp6KnSUZJTXoG3Q7BlyAtU5Seuh7QDphwKxb0+nVO8qBjI0VVGDAByeKLDsTezyurgNpRbcdpZgQElPrFvkP9xXsYX9UEMFrsPc+bdHcJOlgXB7IOABHHcql4kJ4VGmXJbuaNaT+VOa4KX/iQI+rSrZO2z0BQY1idEJUoAhATt0g+Om89ZF7+8IC0D4Y4I7lY5UCS2sqIkuCVUfWr2IbSkc4Q+bnRtGPFTxXIPLVjR9adh4wtc8SvMpz7g/mQGfn9726/05KuWvd1WjTroHS9zVQtPvRIRhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tv1/lg+fS5uRZLHFTJSqme894BakibugG9if2V9GyIo=; b=bmETYuiPgrQMkFeN83nzZ0OoPbU20Ethxz1/Ocrj65TettwGSgZfha8QROs88/ZhNzJV8rUuDE555mxhkp5tRqrVBIUrBSaH/Qx5f1S54kZ/gqw6CKnWFz31XfLTY640XGvM+VWYvsdMINBeP/RGg+N/osYNSdGAvzQqzuUR01c= Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by PH0PR10MB5546.namprd10.prod.outlook.com (2603:10b6:510:d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 07:59:32 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::70df:cb31:cf08:5b12]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::70df:cb31:cf08:5b12%9]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 07:59:32 +0000 Date: Fri, 6 Jan 2023 01:59:39 -0600 From: "Guillermo E. Martinez" To: Alan Modra Cc: binutils@sourceware.org, cgen@sourceware.org Subject: Re: Compute correct mask and values when offset in define-ifield is not 0 Message-ID: <20230106075939.jxsf32av4bzysyqo@kamehouse> References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BY5PR20CA0007.namprd20.prod.outlook.com (2603:10b6:a03:1f4::20) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR10MB1407:EE_|PH0PR10MB5546:EE_ X-MS-Office365-Filtering-Correlation-Id: cd862b75-a0e2-44f8-d98a-08daefbbf20b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zLOHUeq+W+NksJ04V+hd1H384+jHPR20sVyHM0LxIyhYThFzWYDqTQfaQUaE2f0jnz6shVieh/O6g6Pe8JFhK94kjSypnigEZVE6IKjvG1tzLUY3HC/SLuVUiHwSRI1kvs9FcIYEsZ0QD1092pzFCGK0rUU13s0PeNQKLehw39vTYQOA9yfw/S6nuiLSaxaYyDv9tFA648phPRL8VsXG8Cke7RX/PQINxBvCg2W8Wr6eSJy/NSXduekB7yL/fYE9eCv9DamEGV6IvwL/L8xo1rUFCC/7z7ist7Pa2vcjqP87pg2erBTFw3dGIOzBLccohQlLaLmlLRASi3P/xcEmXjpYrH14BdpXlEeWOQ7z04S1RVLHir/vD4o9pFWCOa3OpngjtEYkxQZKGjUZweUyYen3gu+tIs4wbjyh6FhIpFV29UYUxtR2hTjOMmThXIrgjzXq+P9lQ7fbf+OANy1LRT/OwD2jRxD9OU9DMnZ246X/RBez7scVfqPo3ZKvfmBji1CqXaSIFaRhpaRBHiKlKEbcdQtY7PRYxhwwx3n2OhXgo73LSn4WNlZitsaD4P29Imhy/8mZsy7nobA4QIZafDvotTdLZX0sXRYCdV/8GWM5RAmfvKcm6ZFqH13CoE/jdauILxOFL8DCjA3G0HhoQ3TGqbnbiLEX1HpLZOxY31M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1407.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(86362001)(83380400001)(41300700001)(8936002)(2906002)(38100700002)(5660300002)(33716001)(4326008)(186003)(6512007)(6506007)(1076003)(316002)(26005)(66476007)(9686003)(66946007)(6486002)(966005)(6916009)(66556008)(478600001)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEFYdnlzejZSTER6M2RNcXBXc0xENXdyZGVyc3V2a1ZlZjBYWi9BTC94YmVq?= =?utf-8?B?TmwvNFpYTlFRa04xbG5FOFlaWFNlUHYxWkNiLzV1QVNyRGt6K3lrVU5CVjJL?= =?utf-8?B?czFMZWZxZUV1VWZWRTJNWGN2dVVWZ0lGbnlVNXBQQ05iV0FDMUIyUmxXMEJj?= =?utf-8?B?TGdEWDVqRDltWVlCYWQwQ1ZFdzJ1dmRTWlpJb1dFblczMm8zWlVldWtjU0E3?= =?utf-8?B?d3hob1B0V0xhL29heURlb3Y1NHJJS3E4UVpmYi9FR0xFb2YvY3dadHJjQkdN?= =?utf-8?B?ZFpRaGF3Z2xOL243eTRZWE9sQ1UwMHdmUER2dXVqN3lrUW5ia1Z3RUpxR2lo?= =?utf-8?B?dXRMVDhxTTYzVGtnK2lienZaeGxxeVYyV0JQUCtWYTR5Q01KcmNNWHlQZ0tR?= =?utf-8?B?aVhQVWdtQXRGbS9CN1RDcWxMaHRpN2xmWFZIVE85eWx5RTBwUTMyK1ZkSnRB?= =?utf-8?B?MEt2cUtJNnVnbWg5MzZVK092b1FnNzJLUEs0RmJTSDZ5NGg5N2RHNFMvYVlF?= =?utf-8?B?UDRTUzZtRnQzelRYMVhneXdjZVBiVVp6Q0tTNnB4aTFhbDB5dHRhUUhvYzd3?= =?utf-8?B?dGxxMFNReU14VUd4ODFtMU56SmdVOEQ3R3NJZnlmcHptSHlFQ3NXZlg5Y3VU?= =?utf-8?B?SHVSVzdHWXB4YWJEenB3L1ByK0dnSFN3VTl3UUpMSUE1TUVicFdDZkp4UVNB?= =?utf-8?B?SGdrTHBOM051bGlkZTB5TFI4bnRFOW9QT1RHRE1pajUvSVFOWEZ1dkUrd3Ry?= =?utf-8?B?TWVZV1o5Lys0bWgzRllYSG1EWEV3TUtRNGFGeVhmaEVaSnRhRHNsTGlsaGRs?= =?utf-8?B?ZW43cU5hdkE2bzBML2htOWs2SHA1Z0Z1T09xVzVKYUNUS1hLZ0dkRVVHdlA5?= =?utf-8?B?NGJvcGtDNFdDcGYwaEdkWEpMOXk2TGE3TmFwU3I5REcxSWNxY21CWit6UTI4?= =?utf-8?B?V0l0RHRqTUZGaDJNMitrTjNEUXh1ODg3NzVYZ2tYazNDMFQ4ZHlrR3B3eVFl?= =?utf-8?B?VjUwdHdiT3NFZ3dUVjRpVkJGaFhBeWxTUjNJdlNtVVVLNXBYNUR0OHdmK25r?= =?utf-8?B?Q29WOWRRSTJIY2IvQWFsblRKK3BEd2EvcmdFL1EvL2dqZ0EwM3J6NEZaQnFN?= =?utf-8?B?elFYQ1lmREV0a0JpemhhYVVZZ2d2UHpqblByM3BYTm94MHgyeVo3dlZMeGNa?= =?utf-8?B?MDZTT1BKdGdKZ3g5TEl4ZEJ0SGdwVWJHZHFaajlqUEExRkl0RmFyUFJEbUFv?= =?utf-8?B?K042TFRSOFAydVlMUnhST3ZMS1lLTHFJcmlqMEVlZm50WnZuM1Yzd1JqVEhz?= =?utf-8?B?KzNHZU0xZXVEZ0FJMHRKcVZmWkRnRWVWR0VPM2t6VUl1NzhSUnJhNmtvaEVr?= =?utf-8?B?MlBYWXJCdmRGSWtlVDNJa3l3eXRWRzN5NzlQSE9MMnRHV3JXOXhMUi82Nmgz?= =?utf-8?B?NzczVlljeFFtaGJSSk5zc3dMaFRaT2tGYzRONWQ2NHVwdkhSelhZbW5QdjJa?= =?utf-8?B?L241dW41MDN0NUhjTERwcXVUcUJKWHNDTmtxK0F1WUsxMmdlMWs3TllPS2pH?= =?utf-8?B?eTZtZVVPTXdRMkRXZTY1MzRNbmZxaEVLc3NYNHg0N3lpeEN1QjJ4TFlqWFdM?= =?utf-8?B?VTlKQkNmU0ZHV2tSTHRTVEU1RUp3YnYvNVFEOVBBR1B1alJsYUVYaFhMUzI0?= =?utf-8?B?azAxWTVicWwzdHBQZCt5aFNUZTBNN2Z2VFNsZkhaY3NxNlVCMVQxdmFYVXNT?= =?utf-8?B?YU1aRUlUbnlQZXJyQklmd0ZDelpZMnBiUy9BcmJMRUdoSUR4TXBtREZWYXV3?= =?utf-8?B?T3dBdlJ4bVYwb002dVo5cXlYU3NmYUUwQThKUFZlOWJKakx0MGMzdmplWmVD?= =?utf-8?B?bURkUXdsNnd2VFUwS0NyaGJkOG93WVZBN3luMHNFUHlSa0pFb1VhQXRYRUFD?= =?utf-8?B?NWZCOEFpL0h3ckFpbHdVUnRJSlJhOTdYNDdiOWgxZzMrZ2kvT2g0aUhDMlln?= =?utf-8?B?UWUxMWcvWUtEZzBwdTRTZ3JZR1RVRmtad21lVXdVQk9lNWx3MVN4TU0ramZv?= =?utf-8?B?cExsTFlYa0lpcGFPYndMbnRuanFkUHVxdzUrbEZCQm5OTDJwUUdlNzc0OFFj?= =?utf-8?B?WlBIamNLZ2pIcFdGWTZQd0NJN1FVYTJoOEt1aERXVVlERFh4dWdjYkRrRGRh?= =?utf-8?Q?1khKHd/Qsg8ml6ix46Y65KA=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yyBpQjY7irQC4PTeU3uMWFkBwczyxVe0fmeTQoXSe0YVIgKB+hnLY0Q0CuwwEm+BEiP9pVKkAXZduv0O0COzzARFRKjwyWZRZwyJk6S70Vxvjt7PDlXzlH7S/25EgnrENeBWnNgRmZNbbQ1mfj96hWGlgFt3O+FDgkEGZdI6i7j8Gsz2aKVc/Z0CSb0iYC3FJZ0vTh5yuM5zRrqApns10sRP/LPWKlfqgdoHBtxd/bVbFf0NIG3wdQBpDuaxn3enBjOgXaMuE024BwIgeGCB4zX6M5VBNA8hburS3HKariNw7dNexPi3w9fpMwP5vQD84Pq2tofp7krVkk31Fc+m1d+tQaENe47ylh469pyQu3vj4fUnRMzkEZW/yU4Yx8zS+gDwaxM/VNkGjetQNKgtorWR5ln26vmaTZDOZZIDWrKEwWGYg6XU8d2zjt/6wuFzRULqLkLevkYi7epwEzqfETlbKV9yVM4I8xgAB5uSN8niAJFCTFzmWzpvMfFgvDR/bzz54GfVfPxQIQvEh8dgH+2OtySsmUgiqqeHTpA3nrnVhGGknNb6F2fBu45Z0EFX+agnmot2vCBeZOkVEkrACcdO4N1U9kxZZDgzfjwflKykj1e0XMeT41hztUIynHKKEat1pCg9zklpKkF0GCJCWltpnl55ULEjZ64Jln9QO637l0hU19yq9/V9cGAcsGUMwdZuWxGBfYu/6+96VKUR2IxE/a21opunAHte63pe18gWKlgUgQxx3LPOMTv1XxqfTR3CtItqteaOzQDw17CKS0+ksCOTVNHAD1FUfTAz3oOlT/5a7p7g3VQ54GTZjNuH X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd862b75-a0e2-44f8-d98a-08daefbbf20b X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 07:59:32.7007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CmpG6ieRk+5cZxm48ehbavo9oyymWWZrOGJWYxHUbtQ3xgmjxYiINVS7Tgnqe2rLzPARhgP2HbFu9jkmmT6lFwb/4B8Hw4+nQKZYv70jSkw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5546 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_03,2023-01-05_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0 bulkscore=0 mlxlogscore=752 spamscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060062 X-Proofpoint-GUID: -HDej8UcvEDfYVDCXNWDAv9TIBO5S7Fo X-Proofpoint-ORIG-GUID: -HDej8UcvEDfYVDCXNWDAv9TIBO5S7Fo X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Alan, On Fri, Jan 06, 2023 at 11:22:55AM +1030, Alan Modra wrote: > Updating the copyright dates this year reminded me that I have a cgen > patch of yours, commit d1dd5fcc38ea, reverted in order to build > binutils. Without the reversion there are 10 or so errors like > .../opcodes/bpf-opc.c:57:11: error: conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709486335’ to ‘4294902015’ [-Werror=overflow] > 57 | 64, 64, 0xffffffffffff00ff, { { F (F_IMM32) }, { F (F_OFFSET16) }, { F (F_SRCLE) }, { F (F_OP_CODE) }, { F (F_DSTLE) }, { F (F_OP_SRC) }, { F (F_OP_CLASS) }, { 0 } } > | ^~~~~~~~~~~~~~~~~~ > > What's more, if I build with --disable-werror, then the following > testsuite fails show up: > gas/ > +FAIL: eBPF CALL instruction > +FAIL: eBPF CALL instruction, big endian Ooh, sorry for inconvenience. This is because CGEN patch (d1dd5fcc38ea) revealed an disassemble error in binutils for eBPF `call' instructions constructed by expressions using symbols (BPF_PSEUDO_CALL), and the use of a wrong size type to handle the mask CGEN instruction format. I posted a patch to fix it: https://sourceware.org/pipermail/binutils/2023-January/125517.html > ld/ > +FAIL: CALL with disp32 reloc > +FAIL: CALL with disp32 reloc and addend > +FAIL: CALL check unsigned underflow > > All caused by failure of call insns to disassemble with your patch > applied. Please fix, or revert in the cgen sources. > > -- > Alan Modra > Australia Development Lab, IBM Apologies and Kind regards, guillermo