From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19033 invoked by alias); 26 Jun 2018 04:24:44 -0000 Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org Received: (qmail 18857 invoked by uid 89); 26 Jun 2018 04:24:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Frank, memories, cgen, H*r:sk:cgen@so X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jun 2018 04:24:24 +0000 Received: from zbook-ubuntu.localnet ([87.163.4.53]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MEtba-1fN9nX2Uig-00FyMN for ; Tue, 26 Jun 2018 06:24:01 +0200 From: Christian Eggers To: cgen@sourceware.org Subject: Re: Non-contiguous opcodes Date: Tue, 26 Jun 2018 04:24:00 -0000 Message-ID: <2955033.PFIPEQPk1t@zbook-ubuntu> In-Reply-To: <20180623002359.GB11259@redhat.com> References: <2495676.YSRq6Q5dSM@zbook-ubuntu> <20180623002359.GB11259@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00005.txt.bz2 Dear Frank, Am Samstag, 23. Juni 2018, 02:23:59 CEST schrieb Frank Ch. Eigler: > Without digging into the ISA deeply, nor the two-decade-old memories, > have you considered not doing it that way? Consider instead treating > the opcode-like subfields separately inside the define-normal-insn. > So ditch the single insn-enum as it is, and instead of: > > (define-normal-insn > revblo "Reverse Low Order Bytes" () > "revblo $r" > (+ OP_REVBLO r) > [...] > ) > > try: > > (define-normal-insn > revblo "Reverse Low Order Bytes" () > "revblo $r" > (+ (f-op15x5 17) (f-op7x8 0) r) > [...] > ) I already tried this way and it's working. Perhaps I'll will try to put the non-contiguous opcode parts into separate enums (similar to fr30.cpu). BTW: It's some ago seems the last commit into CVS. There may be some items which should be done (support for newer guile, error messages, ...). Do you think that cgen should be moved to binutils? regards Christian