From: "J. Johnston" <jjohnstn@cygnus.com>
To: geoffk@redhat.com
Cc: cgen@sources.redhat.com
Subject: Re: patch for suffixes like '.b.w' using keywords
Date: Wed, 27 Jun 2001 12:48:00 -0000 [thread overview]
Message-ID: <3B3A386C.41A3482C@cygnus.com> (raw)
In-Reply-To: <200106252224.f5PMOX710946@thief.cygnus.com>
Geoffrey Keating wrote:
>
> This patch slightly extends my last keyword-parsing patch to allow
> special first characters in a keyword to be treated differently than
> other special characters. As an example, if you have a keyword set
> "a" "foo_bar" ".foo", the parser will consider any sequence of
> characters starting with any character and continuing with
> alphanumerics and '_' to be a possible keyword. Thus, "a.b" will
> match "a", but "foo_bar_baz" will not match anything.
>
> This works on both internal ports that have been discussed in this
> context. I think it's likely to be the best that can be done
> that's simpler than a proper finite state machine.
>
> Is this OK to commit?
>
Please check it in. I have talked to Frank and he approves.
-- Jeff J.
> --
> Geoff Keating <geoffk@redhat.com>
>
> ===File ~/patches/cgen-keywordfirstspecial.patch============
> 2001-06-19 Geoffrey Keating <geoffk@redhat.com>
>
> * cgen-asm.c (cgen_parse_keyword): Allow any first character.
> * cgen-opc.c (cgen_keyword_add): Ignore special first
> character when building nonalpha_chars field.
>
> Index: opcodes/cgen-asm.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/opcodes/cgen-asm.c,v
> retrieving revision 1.21
> diff -p -u -p -r1.21 cgen-asm.c
> --- cgen-asm.c 2001/06/14 21:00:28 1.21
> +++ cgen-asm.c 2001/06/19 07:55:33
> @@ -212,6 +212,12 @@ cgen_parse_keyword (cd, strp, keyword_ta
>
> p = start = *strp;
>
> + /* Allow any first character. This is to make life easier for
> + the fairly common case of suffixes, eg. 'ld.b.w', where the first
> + character of the suffix ('.') is special. */
> + if (*p)
> + ++p;
> +
> /* Allow letters, digits, and any special characters. */
> while (((p - start) < (int) sizeof (buf))
> && *p
> Index: opcodes/cgen-opc.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/opcodes/cgen-opc.c,v
> retrieving revision 1.28
> diff -p -u -p -r1.28 cgen-opc.c
> --- cgen-opc.c 2001/06/14 21:11:59 1.28
> +++ cgen-opc.c 2001/06/19 07:55:33
> @@ -134,7 +134,7 @@ cgen_keyword_add (kt, ke)
> if (ke->name[0] == 0)
> kt->null_entry = ke;
>
> - for (i = 0; i < strlen (ke->name); i++)
> + for (i = 1; i < strlen (ke->name); i++)
> if (! isalnum ((unsigned char) ke->name[i])
> && ! strchr (kt->nonalpha_chars, ke->name[i]))
> {
> ============================================================
prev parent reply other threads:[~2001-06-27 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-25 15:24 Geoffrey Keating
2001-06-27 12:48 ` J. Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B3A386C.41A3482C@cygnus.com \
--to=jjohnstn@cygnus.com \
--cc=cgen@sources.redhat.com \
--cc=geoffk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).