From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15748 invoked by alias); 9 May 2006 18:45:23 -0000 Received: (qmail 15739 invoked by uid 22791); 9 May 2006 18:45:22 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 May 2006 18:45:19 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k49IjHOW019996 for ; Tue, 9 May 2006 14:45:17 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k49IjHod016159 for ; Tue, 9 May 2006 14:45:17 -0400 Received: from [172.16.14.227] (IDENT:GoDUyTOdH1I/TYLBBC0ljWuHq8ThZ7QF@topaz.toronto.redhat.com [172.16.14.227]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id k49IjHAc014548 for ; Tue, 9 May 2006 14:45:17 -0400 Message-ID: <4460E33D.1090806@redhat.com> Date: Tue, 09 May 2006 18:45:00 -0000 From: Dave Brolley User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) MIME-Version: 1.0 To: cgen@sources.redhat.com Subject: [patch][commit] Typo in utils-sim.scm Generating Decoder Content-Type: multipart/mixed; boundary="------------060901090806000904000103" X-IsSubscribed: yes Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00021.txt.bz2 This is a multi-part message in MIME format. --------------060901090806000904000103 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 272 Hi, I've committed this patch which corrects a typo in the generation of the decoder. The generated code was intended to shift 'entire_insn' to the right when the insn length is less than the base insn size. Tested on an internal port which exposed the problem. Dave --------------060901090806000904000103 Content-Type: text/plain; name="cgen-decode.ChangeLog" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cgen-decode.ChangeLog" Content-length: 151 2006-05-09 Dave Brolley * utils-sim.scm (-gen-decode-insn-entry): Generated code should shift 'entire_insn' not 'base_insn'. --------------060901090806000904000103 Content-Type: text/plain; name="cgen-decode.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cgen-decode.patch.txt" Content-length: 1282 Index: cgen/utils-sim.scm =================================================================== RCS file: /cvs/src/src/cgen/utils-sim.scm,v retrieving revision 1.14 diff -c -p -r1.14 utils-sim.scm *** cgen/utils-sim.scm 5 Dec 2005 01:27:23 -0000 1.14 --- cgen/utils-sim.scm 9 May 2006 18:39:16 -0000 *************** *** 1,5 **** ; Generic simulator application utilities. ! ; Copyright (C) 2000, 2005 Red Hat, Inc. ; This file is part of CGEN. ; See file COPYING.CGEN for details. --- 1,5 ---- ; Generic simulator application utilities. ! ; Copyright (C) 2000, 2005, 2006 Red Hat, Inc. ; This file is part of CGEN. ; See file COPYING.CGEN for details. *************** *** 631,637 **** (if (and (equal? APPLICATION 'SID-SIMULATOR) (> (state-base-insn-bitsize) (insn-length insn))) (string-append ! indent " entire_insn = base_insn >> " (number->string (- (state-base-insn-bitsize) (insn-length insn))) ";\n") "") --- 631,637 ---- (if (and (equal? APPLICATION 'SID-SIMULATOR) (> (state-base-insn-bitsize) (insn-length insn))) (string-append ! indent " entire_insn = entire_insn >> " (number->string (- (state-base-insn-bitsize) (insn-length insn))) ";\n") "") --------------060901090806000904000103--