From: Dave Brolley <brolley@redhat.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: cgen@sources.redhat.com
Subject: Re: Problem with object->string Change in sid-cpu.scm -- patch committed
Date: Tue, 09 May 2006 19:04:00 -0000 [thread overview]
Message-ID: <4460E7B7.8030305@redhat.com> (raw)
In-Reply-To: <20060509184422.GC13413@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
Frank Ch. Eigler wrote:
>OK. Other places in sid-cpu.scm apply symbol->string to mode values,
>so that should be safe here. So might obj:name.
>
>
>
That does the trick. Thanks! The attached patch has been committed.
Dave
[-- Attachment #2: cgen-symbol.ChangeLog --]
[-- Type: text/plain, Size: 196 bytes --]
2006-05-09 Dave Brolley <brolley@redhat.com>
* sid-cpu.scm (-gen-hw-stream-and-destream-fns): Use symbol->string instead of
object->string om the mode.
(-hw-gen-write-stack-decl): Likewise.
[-- Attachment #3: cgen-symbol.patch.txt --]
[-- Type: text/plain, Size: 1926 bytes --]
Index: cgen/sid-cpu.scm
===================================================================
RCS file: /cvs/src/src/cgen/sid-cpu.scm,v
retrieving revision 1.16
diff -c -p -r1.16 sid-cpu.scm
*** cgen/sid-cpu.scm 9 May 2006 18:07:51 -0000 1.16
--- cgen/sid-cpu.scm 9 May 2006 18:57:12 -0000
*************** namespace @arch@ {
*** 212,218 ****
(write-stacks
(map (lambda (n) (sa n "_writes"))
(append (map (lambda (r) (gen-c-symbol (obj:name r))) regs)
! (map (lambda (m) (sa (object->string m) "_memory")) useful-mode-names))))
(stream-reg (lambda (r)
(let ((rname (sa "hardware." (gen-c-symbol (obj:name r)))))
(if (hw-scalar? r)
--- 212,218 ----
(write-stacks
(map (lambda (n) (sa n "_writes"))
(append (map (lambda (r) (gen-c-symbol (obj:name r))) regs)
! (map (lambda (m) (sa (symbol->string m) "_memory")) useful-mode-names))))
(stream-reg (lambda (r)
(let ((rname (sa "hardware." (gen-c-symbol (obj:name r)))))
(if (hw-scalar? r)
*************** typedef struct {
*** 406,415 ****
; (pipe-sz (+ 1 (max-delay (cpu-max-delay (current-cpu)))))
; (sz (* pipe-sz (-worst-case-number-of-writes-to nm))))
! (mode-pad (spaces (- 4 (string-length (object->string mode)))))
(stack-name (string-append nm "_writes")))
(string-append
! " write_stack< write<" (object->string mode) "> >" mode-pad "\t" stack-name "\t[pipe_sz];\n")))
(define (-hw-gen-write-struct-decl)
--- 406,415 ----
; (pipe-sz (+ 1 (max-delay (cpu-max-delay (current-cpu)))))
; (sz (* pipe-sz (-worst-case-number-of-writes-to nm))))
! (mode-pad (spaces (- 4 (string-length (symbol->string mode)))))
(stack-name (string-append nm "_writes")))
(string-append
! " write_stack< write<" (symbol->string mode) "> >" mode-pad "\t" stack-name "\t[pipe_sz];\n")))
(define (-hw-gen-write-struct-decl)
prev parent reply other threads:[~2006-05-09 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 17:57 Problem with obj->string Change in sid-cpu.scm Dave Brolley
[not found] ` <20060509180030.GB13413@redhat.com>
[not found] ` <4460DEBE.801@redhat.com>
2006-05-09 18:44 ` Problem with object->string " Frank Ch. Eigler
2006-05-09 19:04 ` Dave Brolley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4460E7B7.8030305@redhat.com \
--to=brolley@redhat.com \
--cc=cgen@sources.redhat.com \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).