From: Ronald Hecht <ronald.hecht@uni-rostock.de>
To: cgen@sourceware.org
Subject: Simulator: base_insn and insn in decode.c
Date: Mon, 31 Jul 2006 11:58:00 -0000 [thread overview]
Message-ID: <44CDF0AC.6070707@uni-rostock.de> (raw)
Hello again,
i found another problem in decode. c. As I have variable instruction
size, decode.c does not handle base_insn and insn in the right way. The
file looks like this:
const IDESC *
proc8bf_decode (SIM_CPU *current_cpu, IADDR pc,
CGEN_INSN_INT base_insn, CGEN_INSN_INT entire_insn,
ARGBUF *abuf)
{
/* Result of decoder. */
PROC8BF_INSN_TYPE itype;
{
CGEN_INSN_INT insn = base_insn;
{
unsigned int val = (((insn >> 0) & (63 << 0)));
switch (val)
{
case 0 :
if ((entire_insn & 0xff) == 0x0)
{ itype = PROC8BF_INSN_NOP; goto extract_sfmt_nop; }
itype = PROC8BF_INSN_X_INVALID; goto extract_sfmt_empty;
case 1 :
if ((entire_insn & 0xff) == 0x1)
{ itype = PROC8BF_INSN_LDA; goto extract_sfmt_lda; }
itype = PROC8BF_INSN_X_INVALID; goto extract_sfmt_empty;
case 2 :
if ((entire_insn & 0xff) == 0x2)
{ itype = PROC8BF_INSN_LDC; goto extract_sfmt_ldc; }
itype = PROC8BF_INSN_X_INVALID; goto extract_sfmt_empty;
<snip>
I have given the first instruction byte as base_insn and entire_insn is
the complete instruction. The location of the base instruction depends
on the instruction size. So the calculation
unsigned int val = (((insn >> 0) & (63 << 0)));
is not correct. If I remove the if-statement around the goto
extract_sfmt_<insn> everything works correct. The simulatior does the
right things.
By the way: I found it a bit confusing to write mloop.in. It was
difficult to handle different size instructions. I did it this way:
xextract-pbb)
# Inputs: current_cpu, pc, sc, max_insns, FAST_P
# Outputs: sc, pc
# sc must be left pointing past the last created entry.
# pc must be left pointing past the last created entry.
# If the pbb is terminated by a cti insn, SET_CTI_VPC(sc) must be called
# to record the vpc of the cti insn.
# SET_INSN_COUNT(n) must be called to record number of real insns.
cat <<EOF
{
const IDESC *idesc;
int icount = 0;
while (max_insns > 0)
{
CGEN_INSN_INT insn;
CGEN_INSN_INT base_insn = GETIMEMUQI (current_cpu, pc);
idesc = @cpu@_decode(current_cpu, pc, base_insn, base_insn,
&sc->argbuf);
switch (idesc->length) {
case 1 : break;
case 2 :
insn = base_insn * 256 + GETIMEMUQI (current_cpu, pc + 1);
break;
case 3 :
insn = base_insn * 256 * 256 + GETIMEMUQI (current_cpu, pc + 1) *
256 + GETIMEMUQI (current_cpu, pc + 2);
break;
}
idesc = @cpu@_decode(current_cpu, pc, base_insn, insn, &sc->argbuf);
@cpu@_fill_argbuf (current_cpu, &sc->argbuf, idesc, pc, FAST_P);
if (! FAST_P) {
int trace_p = PC_IN_TRACE_RANGE_P (current_cpu, pc);
int profile_p = PC_IN_PROFILE_RANGE_P (current_cpu, pc);
@cpu@_fill_argbuf_tp (current_cpu, &sc->argbuf, trace_p, profile_p);
}
++sc;
--max_insns;
++icount;
pc += idesc->length;
if (IDESC_CTI_P (idesc))
{
SET_CTI_VPC (sc - 1);
break;
}
}
Finish:
SET_INSN_COUNT (icount);
}
EOF
;;
Is there an easier way to write this down?
Ronald
next reply other threads:[~2006-07-31 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 11:58 Ronald Hecht [this message]
2006-08-03 21:55 ` Dave Brolley
2006-08-03 22:08 ` Dave Brolley
2006-08-07 14:39 ` Ronald Hecht
2006-08-07 14:53 ` Ronald Hecht
2006-08-14 21:19 ` Dave Brolley
2006-08-15 8:39 ` Ronald Hecht
2006-08-04 8:51 ` Ronald Hecht
2006-08-14 20:34 ` Dave Brolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CDF0AC.6070707@uni-rostock.de \
--to=ronald.hecht@uni-rostock.de \
--cc=cgen@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).