From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25237 invoked by alias); 18 Jun 2009 05:39:55 -0000 Received: (qmail 25004 invoked by uid 22791); 18 Jun 2009 05:39:55 -0000 X-SWARE-Spam-Status: No, hits=0.3 required=5.0 tests=AWL,BAYES_00,DNS_FROM_RFC_BOGUSMX X-Spam-Check-By: sourceware.org Received: from sebabeach.org (HELO sebabeach.org) (64.165.110.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Jun 2009 05:39:49 +0000 Received: from sspiff.sspiff.org (seba.sebabeach.org [10.8.159.10]) by sebabeach.org (Postfix) with ESMTP id C0D616E3C4; Wed, 17 Jun 2009 22:39:47 -0700 (PDT) Message-ID: <4A39D323.6090406@sebabeach.org> Date: Thu, 18 Jun 2009 05:39:00 -0000 From: Doug Evans User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Masaki Muranaka CC: cgen@sourceware.org Subject: Re: [PATCH] Log message fix References: <842A757C-C343-4363-B406-8A14AA8CCBF5@monami-software.com> In-Reply-To: <842A757C-C343-4363-B406-8A14AA8CCBF5@monami-software.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00040.txt.bz2 Masaki Muranaka wrote: > Hello, > > This is a small and obvious fix. Is ChangeLog entry needed? > > -- > Masaki Muranaka > Monami software > > Hi. Thanks for the patch. It's actually a style issue whether to print this message the former way or the new way with your patch. I realize cgen is inconsistent about this. Darn. E.g. For examples, grep "logit.*Generating" *.scm I don't mind going with your patch, the output is clearer. Technically speaking, all patches require a ChangeLog entry. But I can write one for you for this one. No worries.