From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29867 invoked by alias); 20 Aug 2009 17:35:52 -0000 Received: (qmail 29858 invoked by uid 22791); 20 Aug 2009 17:35:52 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_00,DNS_FROM_RFC_BOGUSMX X-Spam-Check-By: sourceware.org Received: from sebabeach.org (HELO sebabeach.org) (64.165.110.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Aug 2009 17:35:46 +0000 Received: from sspiff.sspiff.org (seba.sebabeach.org [10.8.159.10]) by sebabeach.org (Postfix) with ESMTP id CE0116E3D0; Thu, 20 Aug 2009 10:35:44 -0700 (PDT) Message-ID: <4A8D8970.3090503@sebabeach.org> Date: Thu, 20 Aug 2009 17:35:00 -0000 From: Doug Evans User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Dave Korn CC: cgen@sourceware.org Subject: Re: "make gas-test" broken? References: <4A6B1A40.1020405@gmail.com> <4A8AD9F7.30605@sebabeach.org> <4A8B77A1.8020501@gmail.com> <4A8D82E2.3090805@sebabeach.org> <4A8D88C8.8010404@gmail.com> In-Reply-To: <4A8D88C8.8010404@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00064.txt.bz2 Dave Korn wrote: > Doug Evans wrote: > > >> Ya, that's the problem I was referring to in >> http://sourceware.org/ml/cgen/2009-q3/msg00056.html. >> I've changed method test-data of class to flag a warning and >> compensate. It's not ideal, technically wrong, but for right now I >> don't mind in this particular case. >> > > Ah, gotcha; that's this bit, right? > > >> + ;; If an ifield has, e.g., 2 bits (values 0,1,2,3) and the keyword >> + ;; only has two values, e.g. (foo 0) (bar 1), then we can get >> + ;; invalid requests, i.e. for ifield values of 2 and 3. >> + ;; It's not clear what to do here, but it seems like this is an >> + ;; error in the description file. >> Ya, that's it. > > I also have some ifields like that, they're part of the opcode selection and > not all combinations are valid. (I'll test filling them out with dummy > entries before I update my sandbox just to see if that would have made a > difference.) > Ifields can have assertions to flag invalid values as prohibited. gas-test should honor them but I think it currently doesn't. > >> Ya, this is a change in Guile's behaviour (circa 1.4?). string-append >> use to accept symbols, it no longer does. >> > > I was just about to ask about guile versions. I've been noticing testsuite > FAILs which could be related - I'll take a closer look at any that remain > after I've updated. > Today we support Guile 1.6.8 and 1.8.x. I dropped 1.4.x awhile ago. When to drop 1.6.x is undecided. If you're using 1.8.x I think you're fine.