From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11053 invoked by alias); 21 Aug 2009 06:37:54 -0000 Received: (qmail 11035 invoked by uid 22791); 21 Aug 2009 06:37:53 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_83,SPF_PASS,URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 06:37:43 +0000 Received: by fg-out-1718.google.com with SMTP id e12so140637fga.0 for ; Thu, 20 Aug 2009 23:37:40 -0700 (PDT) Received: by 10.86.211.38 with SMTP id j38mr587397fgg.26.1250836660743; Thu, 20 Aug 2009 23:37:40 -0700 (PDT) Received: from yakj.usersys.redhat.com (nat-pool-brq.redhat.com [62.40.79.66]) by mx.google.com with ESMTPS id 4sm4424316fge.1.2009.08.20.23.37.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 20 Aug 2009 23:37:40 -0700 (PDT) Message-ID: <4A8E40B3.70907@gnu.org> Date: Fri, 21 Aug 2009 06:37:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: Ralf Wildenhues CC: cgen@sourceware.org, gdb-patches@sourceware.org Subject: Re: Fixup readline and sim including of override.m4 References: <20090821054955.GB8004@gmx.de> In-Reply-To: <20090821054955.GB8004@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00069.txt.bz2 On 08/21/2009 07:49 AM, Ralf Wildenhues wrote: > Applying the fopen fixup to override.m4 and rebuilding the autotools > update patch set made it clear that override.m4 wasn't consistently > included everywhere in binutils+gdb yet. > > I used m4_include instead of m4_sinclude so that we'd learn about > failures to include. Unfortunately, m4 inclusion doesn't work the > way C '#include "sub/file"' works (starting relative from the current > file) so that a sinclude would silently fail if a configure.in file were > added that wasn't in a direct subdir of sim (due to the then-wrong > relative paths). > > OK to squash this additional change in (or just commit it before the > patch set)? Ok unless someone complains in 24 hours. Paolo