From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31540 invoked by alias); 5 Oct 2009 18:04:57 -0000 Received: (qmail 31531 invoked by uid 22791); 5 Oct 2009 18:04:56 -0000 X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_00,DNS_FROM_RFC_BOGUSMX X-Spam-Check-By: sourceware.org Received: from sebabeach.org (HELO sebabeach.org) (64.165.110.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Oct 2009 18:04:53 +0000 Received: from sspiff.sspiff.org (seba.sebabeach.org [10.8.159.10]) by sebabeach.org (Postfix) with ESMTP id 07A3A6E3CE; Mon, 5 Oct 2009 11:04:52 -0700 (PDT) Message-ID: <4ACA3543.6000000@sebabeach.org> Date: Mon, 05 Oct 2009 18:04:00 -0000 From: Doug Evans User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Dave Korn CC: cgen@sourceware.org Subject: Re: [patch] One more cpu-vs-prefix fix. References: <4AC18628.9060202@gmail.com> In-Reply-To: <4AC18628.9060202@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact cgen-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00006.txt.bz2 Dave Korn wrote: > Hiya! I found one more place that looks to me like it should be using > @prefix@ instead of @cpu@, since that's how all the rest of the code generates > the "XXX_init_idesc_table" name. > > I haven't tested this much yet except that it fixes a discrepancy between > the prototype generated in the decode.h and the function call in the mloop.c > files for the private port I'm working on. I think that sh64 is the only > target where there actually is any difference between @prefix@ and @cpu@ in > practice, so I tried regenerating it and it seemed to compile ok, or at any > rate without any missing or duplicated symbols. I couldn't get the tests to > run, they all fail with an error that suggests the testsuite is attempting to > run target binaries on the host machine: > > >> spawn /sgun/tools/obj.sh64/ld/ld-new andb.cgs.o -m shelf32 -o andb.cgs.x >> andb.cgs.x >> spawn andb.cgs.x >> andb.cgs.x: andb.cgs.x: cannot execute binary file >> FAIL: sh5 andb.cgs (execution) >> Testing andi.cgs on machine sh5. >> > > So whatever that is, I'd guess it's not related. Here's a changelog entry, > if you want the patch: > > cgen/ChangeLog: > > * sim-model.scm (@cpu@_prepare_run): Use @prefix@, not @cpu@. > > cheers, > DaveK > > Thanks for the patch! I checked it in.