From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jemarch@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 64DB53858C39
 for <cgen@sourceware.org>; Fri, 10 Sep 2021 02:36:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64DB53858C39
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56210)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jemarch@gnu.org>) id 1mOWP5-0003yp-0c
 for cgen@sourceware.org; Thu, 09 Sep 2021 22:36:35 -0400
Received: from [141.143.193.79] (port=13796 helo=termi.gnu.org)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jemarch@gnu.org>) id 1mOWP4-0006HO-PO
 for cgen@sourceware.org; Thu, 09 Sep 2021 22:36:34 -0400
From: "Jose E. Marchesi" <jemarch@gnu.org>
To: "Jose E. Marchesi via Cgen" <cgen@sourceware.org>
Subject: Re: [PATCH CGEN v1] cgen: Compute correct mask and values when
 offset in define-ifield is not 0.
References: <20210820023254.2575757-1-guillermo.e.martinez@oracle.com>
 <7123187.iIbC2pHGDl@sali> <20210910012321.GA19490@redhat.com>
 <87y28540yn.fsf@gnu.org>
Date: Fri, 10 Sep 2021 04:36:31 +0200
In-Reply-To: <87y28540yn.fsf@gnu.org> (Jose E. Marchesi via Cgen's message of
 "Fri, 10 Sep 2021 04:29:52 +0200")
Message-ID: <87bl5140nk.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cgen@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cgen mailing list <cgen.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/cgen>,
 <mailto:cgen-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/cgen/>
List-Post: <mailto:cgen@sourceware.org>
List-Help: <mailto:cgen-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/cgen>,
 <mailto:cgen-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2021 02:36:36 -0000


>>> Just to know if you have some comments to this patch :-)
>>> Thanks in advance.
>>
>> Sorry, no fresh enough knowledge to offer informed commentary.  If
>> your regression tests on other platform indicated no problems, and
>> it solves a real problem with your arch, go for it.
>
> FWIW we reviewed carefully the change internally and it looks good to
> me...

... and of course if we break it, we fix it ;)

/me crosses fingers and toes and...