public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] sim-decode: include cgen-mem & cgen-ops
@ 2021-06-27  3:27 Mike Frysinger
  2021-06-28 21:13 ` Jose E. Marchesi
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2021-06-27  3:27 UTC (permalink / raw)
  To: cgen

The bpf & cris ports use functions from both of these APIs, so include
them here for all ports just in case (and since there isn't an API for
ports to declare specific additional headers they need).
---
 sim-decode.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sim-decode.scm b/sim-decode.scm
index 355c4853022f..cd06d069fdd2 100644
--- a/sim-decode.scm
+++ b/sim-decode.scm
@@ -583,7 +583,10 @@ const IDESC *
 #define WANT_CPU_@CPU@
 
 #include \"sim-main.h\"
-#include \"sim-assert.h\"\n\n"
+#include \"sim-assert.h\"
+#incldde \"cgem-mem.h\"
+#include \"cgen-ops.h\"
+\n"
 
    (lambda () (/gen-decode-insn-globals (non-multi-insns (non-alias-insns (current-insn-list)))))
    /gen-idesc-init-fn
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sim-decode: include cgen-mem & cgen-ops
  2021-06-27  3:27 [PATCH] sim-decode: include cgen-mem & cgen-ops Mike Frysinger
@ 2021-06-28 21:13 ` Jose E. Marchesi
  2021-06-29  1:50   ` Mike Frysinger
  0 siblings, 1 reply; 4+ messages in thread
From: Jose E. Marchesi @ 2021-06-28 21:13 UTC (permalink / raw)
  To: Mike Frysinger via Cgen


> The bpf & cris ports use functions from both of these APIs, so include
> them here for all ports just in case (and since there isn't an API for
> ports to declare specific additional headers they need).

FWIW looks good to me.
Thanks!

> ---
>  sim-decode.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sim-decode.scm b/sim-decode.scm
> index 355c4853022f..cd06d069fdd2 100644
> --- a/sim-decode.scm
> +++ b/sim-decode.scm
> @@ -583,7 +583,10 @@ const IDESC *
>  #define WANT_CPU_@CPU@
>  
>  #include \"sim-main.h\"
> -#include \"sim-assert.h\"\n\n"
> +#include \"sim-assert.h\"
> +#incldde \"cgem-mem.h\"
> +#include \"cgen-ops.h\"
> +\n"
>  
>     (lambda () (/gen-decode-insn-globals (non-multi-insns (non-alias-insns (current-insn-list)))))
>     /gen-idesc-init-fn

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sim-decode: include cgen-mem & cgen-ops
  2021-06-28 21:13 ` Jose E. Marchesi
@ 2021-06-29  1:50   ` Mike Frysinger
  2021-06-29 16:18     ` Jose E. Marchesi
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2021-06-29  1:50 UTC (permalink / raw)
  To: Jose E. Marchesi; +Cc: Mike Frysinger via Cgen

On 28 Jun 2021 23:13, Jose E. Marchesi wrote:
> > The bpf & cris ports use functions from both of these APIs, so include
> > them here for all ports just in case (and since there isn't an API for
> > ports to declare specific additional headers they need).
> 
> FWIW looks good to me.
> Thanks!
> 
> > ---
> >  sim-decode.scm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/sim-decode.scm b/sim-decode.scm
> > index 355c4853022f..cd06d069fdd2 100644
> > --- a/sim-decode.scm
> > +++ b/sim-decode.scm
> > @@ -583,7 +583,10 @@ const IDESC *
> >  #define WANT_CPU_@CPU@
> >  
> >  #include \"sim-main.h\"
> > -#include \"sim-assert.h\"\n\n"
> > +#include \"sim-assert.h\"
> > +#incldde \"cgem-mem.h\"

i managed to have 2 typos in this line.
i fixed them after testing & before pushing :).
-mike

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sim-decode: include cgen-mem & cgen-ops
  2021-06-29  1:50   ` Mike Frysinger
@ 2021-06-29 16:18     ` Jose E. Marchesi
  0 siblings, 0 replies; 4+ messages in thread
From: Jose E. Marchesi @ 2021-06-29 16:18 UTC (permalink / raw)
  To: Mike Frysinger via Cgen


> On 28 Jun 2021 23:13, Jose E. Marchesi wrote:
>> > The bpf & cris ports use functions from both of these APIs, so include
>> > them here for all ports just in case (and since there isn't an API for
>> > ports to declare specific additional headers they need).
>> 
>> FWIW looks good to me.
>> Thanks!
>> 
>> > ---
>> >  sim-decode.scm | 5 ++++-
>> >  1 file changed, 4 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/sim-decode.scm b/sim-decode.scm
>> > index 355c4853022f..cd06d069fdd2 100644
>> > --- a/sim-decode.scm
>> > +++ b/sim-decode.scm
>> > @@ -583,7 +583,10 @@ const IDESC *
>> >  #define WANT_CPU_@CPU@
>> >  
>> >  #include \"sim-main.h\"
>> > -#include \"sim-assert.h\"\n\n"
>> > +#include \"sim-assert.h\"
>> > +#incldde \"cgem-mem.h\"
>
> i managed to have 2 typos in this line.
> i fixed them after testing & before pushing :).

For some reason I have to look at that line like 5 times before my brain
can _see_ the typos.  Hurrah for compilers :D

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-29 16:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-27  3:27 [PATCH] sim-decode: include cgen-mem & cgen-ops Mike Frysinger
2021-06-28 21:13 ` Jose E. Marchesi
2021-06-29  1:50   ` Mike Frysinger
2021-06-29 16:18     ` Jose E. Marchesi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).