From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B34123858C27 for ; Tue, 29 Jun 2021 16:18:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B34123858C27 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15TGGOj1004131 for ; Tue, 29 Jun 2021 16:18:56 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 39f7uu3yfa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jun 2021 16:18:56 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15TFu9Gp068593 for ; Tue, 29 Jun 2021 16:18:55 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by aserp3020.oracle.com with ESMTP id 39dv260dt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jun 2021 16:18:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVWp0++pW8TDge/E1bqaA0UsrHAj+7w0zqynoUNPnOsqU5T66rTXzQeHJnG3BbkZDsned8RwoPpHoBIhNeChBRoMFQ7x+AXGW1zLTOi178rELyj0U8xRBjh220O8uLD/P4U9waJNAiW9bCbFLoGlwR7LmouDCwrEw9oAzTHyyMbpArkHTppyBWSmWyudyH+vhbvnv9zy8MUgKNgRgGAFTCvi8sAVSwNHIugg+a5HijUXaabkUZZjC7KpyMx2eozHaxIiDYEhEF3Llyz4OIhKrfWJlGreuNVBeO83VYdC6gdC8CdPkWbm/NBIUrsImmrBlDE9znVZq5Q7X29Sd/TGlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNw9UzifeIbAM4EMEJYWGJsOKo4RYCVqPNC+KfruHRc=; b=OOAKgTyzCvGPbDQF2BUDMLokSLBblu76FAUM26Sx7RO7WgmJ3m2UYJn56mYJey5PNhc8d/s2y5rGQQ8BVsvwaet6sLqYtMsRzWjyISaMzZJVExrpCbsReoi+oVtP7m3F+aOLUl5dVZtJR0eMnVytxpsk0rNGTiJ5pwW6WHmcxtZY477oFiWp1j8Z0TIlw57mHXFulJkAHqnEk5HvPV4JvdOPH3kOFbHChRdu9zRcyJNN9RXi+Qml89dVpjlc5SeEHCGiGzei5SfSOX4tUis3kElrmSrsbDw5mz1akyCMlMf5zsGFUlXluvqa4EpGMygPB/phLPrjnJAMHjUTYXNbCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) by DS7PR10MB4863.namprd10.prod.outlook.com (2603:10b6:5:297::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Tue, 29 Jun 2021 16:18:53 +0000 Received: from DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::3c15:20ad:f67a:eb04]) by DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::3c15:20ad:f67a:eb04%12]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 16:18:53 +0000 From: "Jose E. Marchesi" To: Mike Frysinger via Cgen Subject: Re: [PATCH] sim-decode: include cgen-mem & cgen-ops References: <20210627032758.1989-1-vapier@gentoo.org> <87y2at8zgi.fsf@oracle.com> Date: Tue, 29 Jun 2021 18:18:46 +0200 In-Reply-To: (Mike Frysinger via Cgen's message of "Mon, 28 Jun 2021 21:50:11 -0400") Message-ID: <87eeck3aqh.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-Originating-IP: [141.143.193.78] X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from termi.oracle.com (141.143.193.78) by FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.12 via Frontend Transport; Tue, 29 Jun 2021 16:18:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5152d273-ba03-4c56-0147-08d93b199693 X-MS-TrafficTypeDiagnostic: DS7PR10MB4863: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: APzcfIoJpGlTgOnQabKLsTNNnhrTZAF0MtUKu7Ppf+ngK+3fAeWvB6dMla8BcINqYsXKzulVSqUcmqzOjxPRAj7DduLeW3M6SpfKpidpE9bM6AaGy81aqpz7k6IEAwxPws9xsV171G5+I79ZuAH4To2D14sCcJsCaAWO2wbyIkJsqXHfBq1M3YdTMI8A7BwxALP4+rO9we2rOZBAIGYJqna2J+09LhApbN6UEVfcplTSL5UGcavKPwssbna3mqa/JeZNoqvxzJatG4KRN+aWVAQAEZDRrFcQIAsO0w+FkT3PMhnfvj12xX7zhJsvRuL/d0C4FFoLoU4elHZWubeH/m8pYwk2Bw7Hgq267DU2pHlV/6q2rY2lXkcr4zdMieqvrR+ZA+93zgkhcbRwh8Oom2O/AKNjeEO/UW/xMbebsca46JrZn8TVPMQS5i0uWKRuvma2DMsuGCB51T1/Bn+AwK7JCnKEb3rb2BOjd1/l4J8M/eOHR7+B1xHXeWcIP85PvECxMW88onUrfrYUzsVnbTD56Fe+bLrQX1eDSDMV3iVtFZIsjGPiu1HOGbESlmSDvopEB/sBGQWnzWi04rlPZ2OWfilAniywQwYEX6e4lyU1SL+lPkGSP/xKQBLhS2FCag3bsu273ogKVTYys8/fbhJdGCwCY9SG3gkeYLTjaKtw/AZSXS2N2lb+bdtDdwDC4jGSYG9KZiR6GDVpPc7Tzg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR10MB2041.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(376002)(39860400002)(396003)(366004)(8936002)(38350700002)(6916009)(38100700002)(4744005)(8676002)(478600001)(66556008)(36756003)(66476007)(66946007)(5660300002)(26005)(2906002)(53546011)(52116002)(7696005)(186003)(16526019)(83380400001)(6666004)(956004)(2616005)(86362001)(6486002)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/kcsP2hDZzSttYNMdZJtKqK/liTL3o6upjPxSgYUjGJ7Yx0wIrYJlp6dJb2k?= =?us-ascii?Q?jhpPOIFVXi5B7kDRLqP8xr9KrUTMoFd0og7Bd8k+ZKiX2V6XkryYZd35bsim?= =?us-ascii?Q?OyD8lYYhpOls6VdNKc45ltEBrjjfc4MKKsF6UZPkQovHu1Lh3JhW2oU8XNyg?= =?us-ascii?Q?Bsg2NGqdJ6VyoLymZKUJPJ+GvRJk95WnP0nsYgYtEDYRmiENmkFGq1GhVv4s?= =?us-ascii?Q?sSnIb4sewdvo9DDJalAq87zVUEXB/N3hioM8qR1NSNlIgUj+IcwsbM+6LFkj?= =?us-ascii?Q?/NIXQFp4TZj/98PxKa7wIxDshPH4uIZes7v/ByAQ9LKPhVyIDZ4Q/CytQsgL?= =?us-ascii?Q?wQjT8rs0/sO6rGDLCzXsFW/h6HXg3jWN5/wADqP30Jz0TbIvmwa2K3hoXPE8?= =?us-ascii?Q?/ELpNw1PWz1AWHukSWZRGuMBHmkPYHpdKOP0Ilk4cMl8r+l4pB4H2thNGgNW?= =?us-ascii?Q?IF8B/TQTLLi8w7kPD5kjQY4Cl3/i6G1pm5AiimxL/NU+w8YE2Lsx6DiWYo66?= =?us-ascii?Q?6ZgHbme9GLq6LoVUAnj4vuI9xvXPa+KM/si3+aKZBuBQGkrIuYGE7HQnLSPd?= =?us-ascii?Q?fT7oEdCZm15x2CIi4uOz5z33QfucyB+gIkCPOKaFLNolhlK5qI0ElqFK3A0c?= =?us-ascii?Q?/HIrlgjp1F/VhtefRv7hG1LExSxsY6ymN+05stH6PgTFVWJYI5FPp5mxk/5l?= =?us-ascii?Q?A28Q4M/EalyrfhcRPOm5xsdH1Xk+gEMk9U3n/mz4m7KIvyn/eQx9u2uasY9d?= =?us-ascii?Q?AT+NM5LfdQibNHqKYevdH4GMOIOZInVM8uSGEotgjYZqXLFEQV1mksnQY4Jk?= =?us-ascii?Q?NPQislfANePRmllwsvyZx7bH8DBHA3SNryPZFEu7URfFikQ5YyeovG6Db0gB?= =?us-ascii?Q?fEGO4F0wz5lJNz13WG9/PfDdVT5j+BC7EG/GTffn/qtRpkCd4S80qoQEM9+W?= =?us-ascii?Q?h/EZOGnzfdKwGp2tfAur0FEhwlFW4hSIDT8RRH2kPAUh8iAth9gkzMdnyA1P?= =?us-ascii?Q?O1mCZYZ+ej+go+pSbrcli9/1rfMJ4OQgQ3iivUDGCSt29Lr+TOcnsVLLRZFp?= =?us-ascii?Q?9wJKaxX6k14RbyqSepMOxz57Wzo7sDlh6tX9wEcPkIf3ye8ftoZBC6ub1AqQ?= =?us-ascii?Q?igbBsZqneA36pwXajvuyebJik3Aj5RWej830snfpgxadaEXPPF5KyR/7SV49?= =?us-ascii?Q?JB2CgDgiKgFm343EIbaMM84Jubw13M96NnzT2o7CSKSjitETu/8PhsQ7qAQ1?= =?us-ascii?Q?lzhMp4fayUyF140nmDQd2+6aAe00oXyIVSx7mqfbmxXzETUiOGFTTk0iru7p?= =?us-ascii?Q?uNewPLOZcJcDgBNj2yJH/ZHL?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5152d273-ba03-4c56-0147-08d93b199693 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB2041.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 16:18:53.8652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 869NJqeFLJglOmv+osDFvj8fNSicQ2qKonI/TUkoqWPkrKsx3RFXfwfSzcY3l9nRfSngjJnjasMR7eKpe6YVjntk3plJa3K7A7kKc6WxPAw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4863 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10030 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106290103 X-Proofpoint-ORIG-GUID: FUigV44ttJPpZi0CWQWFGjTUDWAvmOhh X-Proofpoint-GUID: FUigV44ttJPpZi0CWQWFGjTUDWAvmOhh X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cgen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cgen mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 16:18:58 -0000 > On 28 Jun 2021 23:13, Jose E. Marchesi wrote: >> > The bpf & cris ports use functions from both of these APIs, so include >> > them here for all ports just in case (and since there isn't an API for >> > ports to declare specific additional headers they need). >> >> FWIW looks good to me. >> Thanks! >> >> > --- >> > sim-decode.scm | 5 ++++- >> > 1 file changed, 4 insertions(+), 1 deletion(-) >> > >> > diff --git a/sim-decode.scm b/sim-decode.scm >> > index 355c4853022f..cd06d069fdd2 100644 >> > --- a/sim-decode.scm >> > +++ b/sim-decode.scm >> > @@ -583,7 +583,10 @@ const IDESC * >> > #define WANT_CPU_@CPU@ >> > >> > #include \"sim-main.h\" >> > -#include \"sim-assert.h\"\n\n" >> > +#include \"sim-assert.h\" >> > +#incldde \"cgem-mem.h\" > > i managed to have 2 typos in this line. > i fixed them after testing & before pushing :). For some reason I have to look at that line like 5 times before my brain can _see_ the typos. Hurrah for compilers :D