From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta39.uswest2.a.cloudfilter.net (omta39.uswest2.a.cloudfilter.net [35.89.44.38]) by sourceware.org (Postfix) with ESMTPS id 6F4763858D28 for ; Tue, 22 Aug 2023 16:52:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F4763858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTP id YEoVqteJObK1VYUcKqZ5CE; Tue, 22 Aug 2023 16:52:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id YUcJqLv98Ws6SYUcJqa8zF; Tue, 22 Aug 2023 16:52:31 +0000 X-Authority-Analysis: v=2.4 cv=Sb7ky9du c=1 sm=1 tr=0 ts=64e4e7cf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=okMFy1RTWwuy6qtruU0A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=t3a/Z+WlMReCtzk8qGPc+iz3YzFvN4+QIks7agWq5A4=; b=Iixx5o6gAZPE/VkdCKTpb/Kni4 EQq1p5l4lkeG3f3dxqmzTjU5OsC3clDh/liImDVTS4Gh6il4lgYam11nIH0l8V1gaHVJ1pov1UzTv y4u2Kz7qwTvlJj8ojZzLmmDy7; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:42636 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qYUcJ-000C4K-0A; Tue, 22 Aug 2023 10:52:31 -0600 From: Tom Tromey To: "Jose E. Marchesi" Cc: Tom Tromey , cgen@sourceware.org Subject: Re: [RFC 02/14] Remove some 'fastcall' code References: <20230819174900.866436-1-tom@tromey.com> <20230819174900.866436-3-tom@tromey.com> <874jkurv0w.fsf@gnu.org> X-Attribution: Tom Date: Tue, 22 Aug 2023 10:52:30 -0600 In-Reply-To: <874jkurv0w.fsf@gnu.org> (Jose E. Marchesi's message of "Sun, 20 Aug 2023 10:13:35 +0200") Message-ID: <87il97uii9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qYUcJ-000C4K-0A X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (prentzel) [75.166.142.177]:42636 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFL0zHjw3ZCQrNs5R1rA/pYLgEMb5SJtPVEy7yajLZa8Su2GdFc/754B+v8EK1752SJApVhAcbn/s/nI8To2mcbt8uBtHReAIZVwtTt06T8GPyOIUxly EGIpajqCDcDfpdsqZQoqopVdlHYJ/4I1R4Qvco+eG/Ny5V8jIlMpctpbffu87QJPS64XN30q+ZC1RA== X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> This patch removes this code and in the process removes some >> unnecessary global variables, by turning them into let bindings. Jose> The change LGTM. Jose> The only comment I have is that it seems to me the / prefix for symbol Jose> names seems to be used for globals? I don't think locally let-defined Jose> symbols are to be using that prefix... I removed the leading "/" Tom