From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=cEAG=EF=gnu.org=jemarch@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 3B5B43858C62
	for <cgen@sourceware.org>; Sun, 20 Aug 2023 08:42:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B5B43858C62
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <jemarch@gnu.org>)
	id 1qXe18-00062V-Nz; Sun, 20 Aug 2023 04:42:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
	From; bh=odJWNcXoyfiFAWvCjIFD87DLbdQYUMq9jrrPgJiKyvk=; b=AfOg+A76awxcS6JQw2JQ
	OyLC69SknhwuFpvFEeuDJ2fWyHrF6hi8PSJ7gTHCjHO1/ytBsdX5rJiz9HirfH0jdrvkF5X8s8Kc0
	GZ1OlE57553sRN02D8io5iqnF2SJPozlvFl/RLoZChC5e5bQpW5HY11yi5O0xc8iah7gHWz53WQf6
	CGN5o5aLk0j80j703uRKvRFamGi5xM0py0ORr8AyKQNSnpBXblINBfrPj4g9fvFC2qyFh7QnWaADX
	GXTQsNwI/sKG5QheZj266lePXSgEi3UmnXBd4GzSNvwB7cUS065HMJIBMiVPTgAwJiQj9gLKsXI4P
	s7ZlpVNhTlog6w==;
From: "Jose E. Marchesi" <jemarch@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: cgen@sourceware.org
Subject: Re: [RFC 11/14] Invalid code in rtx-traverse.scm
In-Reply-To: <20230819174900.866436-12-tom@tromey.com> (Tom Tromey's message
	of "Sat, 19 Aug 2023 11:42:10 -0600")
References: <20230819174900.866436-1-tom@tromey.com>
	<20230819174900.866436-12-tom@tromey.com>
Date: Sun, 20 Aug 2023 10:42:34 +0200
Message-ID: <87il9aqf45.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <cgen.sourceware.org>


> The Guile compiler pointed out a 3-argument call to cons in
> rtx-traverse.scm.  Presumably this code is never run, but this patch
> replaces it with what I think is the correct form.

This LGTM.

The same snippet is commented out in rtx-eval-with-estate:

;		; Don't eval operands for syntax expressions.
;		(if (eq? (rtx-style rtx-obj) 'SYNTAX)
;		    (apply fn (cons estate (cdr expr)))
;		    (let ((operands
;			   (/rtx-eval-operands rtx-obj expr estate)))
;		      (apply fn (cons estate operands))))

And it is (apply fn (cons estate (cdr expr))) there.

> ---
>  rtl-traverse.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rtl-traverse.scm b/rtl-traverse.scm
> index de7911a..6023648 100644
> --- a/rtl-traverse.scm
> +++ b/rtl-traverse.scm
> @@ -1757,7 +1757,7 @@
>  	(if (procedure? fn)
>  	    ; Don't traverse operands for syntax expressions.
>  	    (if (eq? (rtx-style rtx-obj) 'SYNTAX)
> -		(apply fn (cons tstate cdr expr))
> +		(apply fn (cons tstate (cdr expr)))
>  		(let ((operands (/rtx-traverse-operands rtx-obj expr tstate appstuff)))
>  		  (apply fn (cons tstate operands))))
>  	    fn)