From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 42B36385841D for ; Sat, 23 Dec 2023 10:32:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42B36385841D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42B36385841D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703327555; cv=none; b=HjSICDacnBWpMHNvSP4+Vztcrrpf3K9pbn/5iBh9NN+EGm9OO8v0a4oVPw1aEXlqeAkWK8p2MsXB+3nkADAg8FrJYbRq3Dto2bCny7z9UQFQB9ar5TM0yCBgoAWtgASlZxswmiw+v+vKXOzfzN15LX85jxus5veUYBla00cJg4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703327555; c=relaxed/simple; bh=EBiEnFn5IPopwm7hoEf/GTcdyVyNK4/5aAR0bApxaYk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=k9a2WP9+8Wx5XMbNuC5cTkHOHPJmoArM75xEeqZto9+ItqHi3nlbsU7ZUH0mDzjStFRoFmfuKrDO2Kjm1wqhrOssd21torD/zhoGgpq2aBUFKJVAbFT8DgPYKIq5W98zbmRq2nqwBqyjCAl3n5BEtyQVtnFN1WLJCdNYrLuVV4g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGzJ2-0000Ef-MI; Sat, 23 Dec 2023 05:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=7VFxEbOgl149PPykKaV3H7ZeXQAt3ZiiXECBxZKJQOU=; b=pVHNnFx2iZBNESDTa41T tutbwF9sD5PgIvPxltngPUYaOEBOflXOHeV1WuCirKmOndZTfEfZck2p5IzHK0Xk9kFGogwTCPl02 qVDr5XjokikDA8F7qHij4PoVkLAN1SvkZPoMu5aKswDZrlXHlImq6rCjTF2YRPGnxj2yJ/HDNQ5Dy BaB4XcSCTvQ35+TAn97h3040s/skGXB1sn7EOsTUS9QwnifyePLgFlH+SMVrkCqalpV9MZ2uTE/Gu 2NwbgoCErZ9HcTlFV1u9ZtIR7r58UI6yoet3o9cFQgB03L5mtK4WAdF+CWx4LMiT6nUSeCeuakMMA QapY9JCMZS0spQ==; From: "Jose E. Marchesi" To: Mike Frysinger Cc: Mike Frysinger via Cgen Subject: Re: [PATCH] sim: tighten up generated decode tables In-Reply-To: (Mike Frysinger's message of "Fri, 22 Dec 2023 14:58:08 -0500") References: <20231222010028.17297-1-vapier@gentoo.org> <87sf3upkub.fsf@gnu.org> Date: Sat, 23 Dec 2023 11:30:58 +0100 Message-ID: <87jzp5nrbx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 22 Dec 2023 11:55, Jose E. Marchesi wrote: >> > The use of /* fall through */ with consective case statements doesn't >> > really add any value, and when generating large files, can take up a >> > lot of space. In the case of cris, it alone adds ~20k, or ~10%. >> >> I am a little concern this change may trigger implicit-fallthrough >> warnings when compiling the generated code. Not sure this is a problem >> in practice though, since nor binutils nor sim uses >> -Wimplicit-fallthrough for building as far as I can see. > > pretty sure compilers don't warn about consecutive case statements that > don't have any non-case code inbetween. so we're talking about: > case 11: > case 12: > case 13: > case 14: itype = CRISV10F_INSN_ADDOQ; goto extract_sfmt_addoq; > > since this is a very common scenario, compilers accept it without warning. > if you did something like: > case 13: > printf(""); > case 14: itype = CRISV10F_INSN_ADDOQ; goto extract_sfmt_addoq; > then it'd warn. > > i'm actually enabling -Wimplicit-fallthrough in sim now and none of these > trigger warnings. OK then. Thanks!