From: "Jose E. Marchesi" <jemarch@gnu.org>
To: cgen@sourceware.org
Subject: Re: [PATCH] sid/sim: constify sim_machs storage
Date: Tue, 14 Sep 2021 21:02:25 +0200 [thread overview]
Message-ID: <87pmtb56bi.fsf@gnu.org> (raw)
In-Reply-To: <YTvVNdLvz6A/Ps+r@vapier> (Mike Frysinger via Cgen's message of "Fri, 10 Sep 2021 17:59:17 -0400")
> ping ...
>
> On 28 Jun 2021 11:34, Mike Frysinger via Cgen wrote:
>> The array itself is read-only, so mark it const.
>> ---
>> sid.scm | 2 +-
>> sim.scm | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sid.scm b/sid.scm
>> index d6d6ed30a890..c34338371d82 100644
>> --- a/sid.scm
>> +++ b/sid.scm
>> @@ -1361,7 +1361,7 @@
>>
>> (define (/gen-mach-data)
>> (string-append
>> - "const MACH *sim_machs[] =\n{\n"
>> + "const MACH * const sim_machs[] =\n{\n"
>> (string-map (lambda (mach)
>> (gen-obj-sanitize
>> mach
>> diff --git a/sim.scm b/sim.scm
>> index f965ef1fcb17..a153f8cee720 100644
>> --- a/sim.scm
>> +++ b/sim.scm
>> @@ -1475,7 +1475,7 @@
>>
>> (define (/gen-mach-data)
>> (string-append
>> - "const SIM_MACH *sim_machs[] =\n{\n"
>> + "const SIM_MACH * const sim_machs[] =\n{\n"
>> (string-map (lambda (mach)
>> (gen-obj-sanitize
>> mach
>> --
>> 2.31.1
>>
This LGTM.
prev parent reply other threads:[~2021-09-14 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:34 Mike Frysinger
2021-09-10 21:59 ` Mike Frysinger
2021-09-14 19:02 ` Jose E. Marchesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmtb56bi.fsf@gnu.org \
--to=jemarch@gnu.org \
--cc=cgen@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).