public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: "Jose E. Marchesi" <jemarch@gnu.org>
To: cgen@sourceware.org
Subject: Re: [PATCH] sim-cpu: stop emitting unused record_trace_results stub function
Date: Fri, 10 Sep 2021 13:49:37 +0200	[thread overview]
Message-ID: <87pmtgy7ji.fsf@gnu.org> (raw)
In-Reply-To: <YTrRx01qiWODsiZG@vapier> (Mike Frysinger via Cgen's message of "Thu, 9 Sep 2021 23:32:23 -0400")


LGTM

> ping ...
>
> On 27 Jun 2021 10:56, Mike Frysinger via Cgen wrote:
>> This isn't called anywhere, and no one implements it, so stop emitting
>> it.  All the cgen ports trigger compiler warnings because of it atm.
>> ---
>>  sim-cpu.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/sim-cpu.scm b/sim-cpu.scm
>> index 454d734e193b..6c848da39273 100644
>> --- a/sim-cpu.scm
>> +++ b/sim-cpu.scm
>> @@ -922,7 +922,8 @@ SEM_FN_NAME (@prefix@,init_idesc_table) (SIM_CPU *current_cpu)
>>  
>>  "
>>     /gen-cpu-reg-access-defns
>> -   /gen-cpu-record-results
>> +   ; This code isn't ready yet.
>> +   ; /gen-cpu-record-results
>>     )
>>  )
>>  
>> -- 
>> 2.31.1
>> 

      reply	other threads:[~2021-09-10 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-27 14:56 Mike Frysinger
2021-09-10  3:32 ` Mike Frysinger
2021-09-10 11:49   ` Jose E. Marchesi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmtgy7ji.fsf@gnu.org \
    --to=jemarch@gnu.org \
    --cc=cgen@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).