From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jemarch@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 7A11B3857C4A
 for <cgen@sourceware.org>; Fri, 10 Sep 2021 11:49:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A11B3857C4A
Received: from fencepost.gnu.org ([2001:470:142:3::e]:33894)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jemarch@gnu.org>) id 1mOf2W-0004Yh-35
 for cgen@sourceware.org; Fri, 10 Sep 2021 07:49:52 -0400
Received: from [141.143.193.69] (port=54032 helo=termi.gnu.org)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jemarch@gnu.org>) id 1mOf2V-0002KN-RX
 for cgen@sourceware.org; Fri, 10 Sep 2021 07:49:52 -0400
From: "Jose E. Marchesi" <jemarch@gnu.org>
To: cgen@sourceware.org
Subject: Re: [PATCH] sim-cpu: stop emitting unused record_trace_results stub
 function
References: <20210627145657.29878-1-vapier@gentoo.org>
 <YTrRx01qiWODsiZG@vapier>
Date: Fri, 10 Sep 2021 13:49:37 +0200
In-Reply-To: <YTrRx01qiWODsiZG@vapier> (Mike Frysinger via Cgen's message of
 "Thu, 9 Sep 2021 23:32:23 -0400")
Message-ID: <87pmtgy7ji.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cgen@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cgen mailing list <cgen.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/cgen>,
 <mailto:cgen-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/cgen/>
List-Post: <mailto:cgen@sourceware.org>
List-Help: <mailto:cgen-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/cgen>,
 <mailto:cgen-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2021 11:49:53 -0000


LGTM

> ping ...
>
> On 27 Jun 2021 10:56, Mike Frysinger via Cgen wrote:
>> This isn't called anywhere, and no one implements it, so stop emitting
>> it.  All the cgen ports trigger compiler warnings because of it atm.
>> ---
>>  sim-cpu.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/sim-cpu.scm b/sim-cpu.scm
>> index 454d734e193b..6c848da39273 100644
>> --- a/sim-cpu.scm
>> +++ b/sim-cpu.scm
>> @@ -922,7 +922,8 @@ SEM_FN_NAME (@prefix@,init_idesc_table) (SIM_CPU *current_cpu)
>>  
>>  "
>>     /gen-cpu-reg-access-defns
>> -   /gen-cpu-record-results
>> +   ; This code isn't ready yet.
>> +   ; /gen-cpu-record-results
>>     )
>>  )
>>  
>> -- 
>> 2.31.1
>>