From: "Jose E. Marchesi" <jemarch@gnu.org>
To: cgen@sourceware.org
Subject: Re: [PATCH] sim: add arch prefix to sim_machs
Date: Tue, 14 Sep 2021 21:01:35 +0200 [thread overview]
Message-ID: <87tuin56cw.fsf@gnu.org> (raw)
In-Reply-To: <YTvVQ1femrUzEsCO@vapier> (Mike Frysinger via Cgen's message of "Fri, 10 Sep 2021 17:59:31 -0400")
> ping ...
>
> On 28 Jun 2021 21:37, Mike Frysinger via Cgen wrote:
>> We want to namespace the sim_machs structure to avoid conflicts when
>> linking multiple architectures into a single build.
>> ---
>> sim.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/sim.scm b/sim.scm
>> index ae61a0939cf0..c7fe822767c3 100644
>> --- a/sim.scm
>> +++ b/sim.scm
>> @@ -1475,7 +1475,8 @@
>>
>> (define (/gen-mach-data)
>> (string-append
>> - "const SIM_MACH * const sim_machs[] =\n{\n"
>> + "const SIM_MACH * const " (symbol->string (current-arch-name))
>> + "_sim_machs[] =\n{\n"
>> (string-map (lambda (mach)
>> (gen-obj-sanitize
>> mach
>> --
>> 2.31.1
>>
This LGTM.
prev parent reply other threads:[~2021-09-14 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 1:37 Mike Frysinger
2021-09-10 21:59 ` Mike Frysinger
2021-09-14 19:01 ` Jose E. Marchesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuin56cw.fsf@gnu.org \
--to=jemarch@gnu.org \
--cc=cgen@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).