From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 928633858C62 for ; Sun, 20 Aug 2023 08:15:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 928633858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXdak-000187-16; Sun, 20 Aug 2023 04:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=bXsmcIR5aOmJDQsqKv1hWO1qjPQGC4dFA7Z3jOUvWP0=; b=ne7U9EBOQU9dNZMkch3Q uKG2kF+SIHQP2Rko6yQQs76XEABMzcSDlizthhuuMA4ypjhyls4hrO7/7Lbj4mxM628WTgA1eVA6+ 19VjZesac0BLuu4JJiBmOyuobUzq1wPca/UTyH341zi0KpSxbYOYPDIyrND5eRRTa9kSKmo/Nzz59 FQ+ArfgutM4llHu8ri2KfBSjOgOk4ixTywZnxfobT6TOQcUImifCJk1HAcdpzwJ7UaEReaCPBTYNI yMLUkgHl+VDt/uaDKELe183CqZCkzB8uiYtLjkUfe4UMQfGZFyRjd+fvvMA/iC/qM5jYY222Blyf3 OuG2VqoVfBXLiA==; From: "Jose E. Marchesi" To: Tom Tromey Cc: cgen@sourceware.org Subject: Re: [RFC 04/14] Remove =? and >=? aliases In-Reply-To: <20230819174900.866436-5-tom@tromey.com> (Tom Tromey's message of "Sat, 19 Aug 2023 11:42:03 -0600") References: <20230819174900.866436-1-tom@tromey.com> <20230819174900.866436-5-tom@tromey.com> Date: Sun, 20 Aug 2023 10:15:17 +0200 Message-ID: <87v8daqgdm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK. Thanks. > =? and >=? are aliases for = and >=. Remove these and update the few > users. > --- > enum.scm | 2 +- > guile.scm | 4 ---- > opcodes.scm | 4 ++-- > sim-test.scm | 4 ++-- > 4 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/enum.scm b/enum.scm > index 1faeb5f..5390e08 100644 > --- a/enum.scm > +++ b/enum.scm > @@ -278,7 +278,7 @@ > "sanitize-" > san-code " */") > "") > - (if (or san? (=? (remainder n 4) 0)) > + (if (or san? (= (remainder n 4) 0)) > "\n " > "") > (if (= n 0) > diff --git a/guile.scm b/guile.scm > index d2b8d8d..85c37d4 100644 > --- a/guile.scm > +++ b/guile.scm > @@ -37,10 +37,6 @@ > ) > ) > > -; FIXME: to be deleted > -(define =? =) > -(define >=? >=) > - > (if (not (symbol-bound? #f '%stat)) > (begin > (define %stat stat) > diff --git a/opcodes.scm b/opcodes.scm > index 66ce9dd..1644fcd 100644 > --- a/opcodes.scm > +++ b/opcodes.scm > @@ -771,12 +771,12 @@ > (begin > (close-port port) > ; End of file, did we find the text? > - (if (=? start -1) > + (if (= start -1) > "" > (substring result start index)))) > ((char=? char #\newline) > ; Check for start delim or end delim? > - (if (=? start -1) > + (if (= start -1) > (if (string=? (substring result line > (+ (string-length start-delim) > line)) > diff --git a/sim-test.scm b/sim-test.scm > index 8176070..3029105 100644 > --- a/sim-test.scm > +++ b/sim-test.scm > @@ -106,8 +106,8 @@ > (let ((test-data (map (lambda (op) (operand-test-data op n)) op-list)) > (len (length op-list))) > ; FIXME: Make slicker later. > - (cond ((=? len 0) (list (list))) > - ((=? len 1) test-data) > + (cond ((= len 0) (list (list))) > + ((= len 1) test-data) > (else (list (map car test-data))))) > )