From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Mike Frysinger via Cgen <cgen@sourceware.org>
Subject: Re: [PATCH] sim-decode: include cgen-mem & cgen-ops
Date: Mon, 28 Jun 2021 23:13:33 +0200 [thread overview]
Message-ID: <87y2at8zgi.fsf@oracle.com> (raw)
In-Reply-To: <20210627032758.1989-1-vapier@gentoo.org> (Mike Frysinger via Cgen's message of "Sat, 26 Jun 2021 23:27:58 -0400")
> The bpf & cris ports use functions from both of these APIs, so include
> them here for all ports just in case (and since there isn't an API for
> ports to declare specific additional headers they need).
FWIW looks good to me.
Thanks!
> ---
> sim-decode.scm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sim-decode.scm b/sim-decode.scm
> index 355c4853022f..cd06d069fdd2 100644
> --- a/sim-decode.scm
> +++ b/sim-decode.scm
> @@ -583,7 +583,10 @@ const IDESC *
> #define WANT_CPU_@CPU@
>
> #include \"sim-main.h\"
> -#include \"sim-assert.h\"\n\n"
> +#include \"sim-assert.h\"
> +#incldde \"cgem-mem.h\"
> +#include \"cgen-ops.h\"
> +\n"
>
> (lambda () (/gen-decode-insn-globals (non-multi-insns (non-alias-insns (current-insn-list)))))
> /gen-idesc-init-fn
next prev parent reply other threads:[~2021-06-28 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 3:27 Mike Frysinger
2021-06-28 21:13 ` Jose E. Marchesi [this message]
2021-06-29 1:50 ` Mike Frysinger
2021-06-29 16:18 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2at8zgi.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=cgen@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).